Skip to content

fix: Add charset to the "content-type" header - #1231

Open
Killian-fal wants to merge 1 commit into
tefra:mainfrom
Killian-fal:fix-content-type
Open

fix: Add charset to the "content-type" header#1231
Killian-fal wants to merge 1 commit into
tefra:mainfrom
Killian-fal:fix-content-type

Conversation

@Killian-fal

@Killian-fal Killian-fal commented Aug 31, 2026

Copy link
Copy Markdown

📒 Description

Client.prepare_headers doesn't add the charset even if the config.encoding is feed.

Resolves #1230

🔗 What I've Done

  1. Client.prepare_headers now add the config.encoding param if defined
  2. Add a unit test

💬 Comments

X

🛫 Checklist

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.97%. Comparing base (1fda878) to head (42b7f0e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1231   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files         116      116           
  Lines        9393     9395    +2     
  Branches     1444     1445    +1     
=======================================
+ Hits         9391     9393    +2     
  Misses          1        1           
  Partials        1        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Client never add "config.encoding" inside the Content-Type header

1 participant