fix(analysis): distinguish Foundry handler assertions - #39
Merged
Conversation
figtracer
marked this pull request as ready for review
August 19, 2026 16:01
mablr
reviewed
Aug 19, 2026
mablr
left a comment
There was a problem hiding this comment.
Makes sense, have you tested it locally on PRs ? foundry-rs/foundry#15818 or foundry-rs/foundry#16065 ?
Author
|
yes, it makes bug discovery time more accurate since it doesn't bundle same target findings @mablr doesn't explain the whole thing but can help on edge cases where it might depend on the pulse |
|
lgtm, ty |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Current Foundry JSON emits handler assertions with
failure_type: handler_assertion, a target address, and a function selector. The analyzer ignored the selector and used only the target, collapsing distinct assertion sites into one bug. A later metrics pulse could restore the total with anonymous synthetic bugs, so the reported count depended on whether that pulse arrived before the run ended.Validation
python -m unittest analysis.tests.test_analyze_foundry_parser -v(13 tests)python -m unittest discover -s analysis/tests -v(128 tests)