Repository navigation
fix(analysis): exclude Foundry showmap replay from cumulative inventory - #44
Open
haileymarshall wants to merge 1 commit into
Open
haileymarshall wants to merge 1 commit into
haileymarshall wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cumulative inventory path walks every
*.logfile, while the event parser excludesfoundry_showmap.log:Given a replay-only logs directory,
build_cumulative_rows(..., logs_dir=...)emitted[("foundry", "run-1:i-abcd1234", 0.0, 0)]even though no benchmark log was parsed.Fix
Add
foundry_showmap.logto the cumulative inventory ignore set so zero-event seeding follows the same input filter as event, throughput, and progress parsing.Tests
Added a regression test covering a replay-only directory. It fails on
mainwith anAssertionErrorbecause the unexpected row above is emitted; with this change the test passes.Validation
uv run --with-requirements analysis/requirements.txt python -m unittest discover -s analysis/tests -p 'test_*.py': 133 tests, OK.python3 -m compileall -q analysis scripts: passed.git diff --check: passed.