feat: default builder cache sharing on#5529
Merged
Merged
Conversation
decofe
force-pushed
the
centaur/1781020071-1677-3121
branch
from
de3ce51 to
f8bf637
Compare
shekhirin
changed the title
decofe
changed the title
shekhirin
force-pushed
the
centaur/1781020071-1677-3121
branch
from
6a19bf6 to
7b0a9b0
Compare
klkvr
previously approved these changes
Jun 11, 2026
…77-3121 # Conflicts: # bin/tempo/src/main.rs
…77-3121 # Conflicts: # bin/tempo/src/main.rs
klkvr
approved these changes
Jun 11, 2026
klkvr
previously approved these changes
Jun 11, 2026
|
Hi @klkvr — your review approval was detected by Voight-Kampff, but you rejected the approval request. Your review did not count toward this PR. The prompt was canceled. This request was for head Re-submit the review and complete the new Voight-Kampff prompt if you want this review to count. |
klkvr
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--builder.enable-prewarmingaccepted as a no-op legacy flag, defaulting to true for compatibility--engine.disable-execution-cache-sharing-with-builderfor explicit opt-outTesting
cargo fmtcargo test -p tempo --bin tempo consensus_block_budget_defaults_are_stablePrompted by: @shekhirin