perf: use concrete protocol best iterator#5531
Closed
tempoxyz-bot wants to merge 1 commit into
Closed
Conversation
Genericize Tempo's merge best-transaction iterator over the protocol source. When payload attributes match the pool's tracked base and blob fees, use the concrete protocol iterator inside the merge and keep the boxed attribute-aware fallback for fee changes.
Contributor
Author
|
derek bench mode=e2e otlp=false |
Member
|
✅ Benchmark complete: Improvement View job ✅ Bench Comparison: ImprovementRefs: main vs auto-opt/20260609-concrete-protocol-best Configuration
Tempo Metrics
Builder
Builder details
Validator
Observability |
Contributor
Author
|
derek bench samply run-pairs=1 duration=300 no-slack |
Member
|
⚪ Benchmark complete: No Difference View job ⚪ Bench Comparison: No DifferenceRefs: main vs auto-opt/20260609-concrete-protocol-best Configuration
Tempo Metrics
Builder
Builder details
Validator
ObservabilitySamply Profiles
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Genericize Tempo's merge best-transaction iterator over the protocol source. When payload attributes match the pool's tracked base and blob fees, use the concrete protocol iterator inside the merge and keep the boxed attribute-aware fallback for fee changes.