Skip to content

perf: use concrete protocol best iterator#5531

Closed
tempoxyz-bot wants to merge 1 commit into
mainfrom
auto-opt/20260609-concrete-protocol-best
Closed

perf: use concrete protocol best iterator#5531
tempoxyz-bot wants to merge 1 commit into
mainfrom
auto-opt/20260609-concrete-protocol-best

Conversation

@tempoxyz-bot

Copy link
Copy Markdown
Contributor

Genericize Tempo's merge best-transaction iterator over the protocol source. When payload attributes match the pool's tracked base and blob fees, use the concrete protocol iterator inside the merge and keep the boxed attribute-aware fallback for fee changes.

Genericize Tempo's merge best-transaction iterator over the protocol source. When payload attributes match the pool's tracked base and blob fees, use the concrete protocol iterator inside the merge and keep the boxed attribute-aware fallback for fee changes.
@tempoxyz-bot tempoxyz-bot self-assigned this Jun 9, 2026
@tempoxyz-bot

Copy link
Copy Markdown
Contributor Author

derek bench mode=e2e otlp=false

@decofe

decofe commented Jun 9, 2026

Copy link
Copy Markdown
Member

cc @tempoxyz-bot

✅ Benchmark complete: Improvement View job

✅ Bench Comparison: Improvement

Refs: main vs auto-opt/20260609-concrete-protocol-best
Criteria: 95% run-bootstrap CI must clear floor; cells show delta (+/-CI/floor).

Configuration

  • Derek command: derek bench mode=e2e preset=tip20 duration=90 bloat=100 tps=50000 accounts=1000 max-concurrent-requests=500 baseline=main feature=auto-opt/20260609-concrete-protocol-best baseline-hardfork="" feature-hardfork="" gas-limit=1000000000 run-pairs=3 otlp=false metrics=false no-cache=false force-bloat=false
  • Bloat: 100000 MiB
  • Preset: tip20
  • Target TPS: 50000
  • Duration: 90s
  • Run pairs: 3
  • Baseline blocks: 480
  • Feature blocks: 482

Tempo Metrics

Metric Baseline Feature Delta
TPS Mean 22372 22320 -0.23% ⚪ (+/-0.54/floor 0.55)
Gas Throughput [Mgas/s] 989.7 987.5 -0.22% ⚪ (+/-0.55/floor 0.50)
Block Time Mean [ms] 555.1 553.7 -0.25% ⚪ (+/-0.26/floor 0.40)
Block Time P50 [ms] 555.0 555.0 +0.00% ⚪ (+/-0.63/floor 0.70)
Block Time P90 [ms] 583.0 582.0 -0.17% ⚪ (+/-0.46/floor 0.70)
Block Time P99 [ms] 601.0 599.0 -0.33% ⚪ (+/-1.28/floor 1.60)
Serialized Block Size / Tx P50 [B/tx] 251.1 251.1 +0.00% ⚪ (+/-0.00/floor 0.70)
Serialized Block Size / Tx P90 [B/tx] 251.1 251.1 +0.00% ⚪ (+/-0.00/floor 0.70)
Serialized Block Size / Tx P99 [B/tx] 251.1 251.1 +0.00% ⚪ (+/-0.00/floor 0.70)

Builder

Metric Baseline Feature Delta
Gas Throughput [Mgas/s] 2364.4 2357.2 -0.31% ⚪ (+/-0.55/floor 0.70)
P50 [ms] 230.1 230.2 +0.04% ⚪ (+/-0.32/floor 0.35)
P90 [ms] 245.5 246.8 +0.53% ⚪ (+/-1.15/floor 0.70)
P99 [ms] 280.1 281.9 +0.64% ⚪ (+/-1.25/floor 0.95)
Builder details
Metric Baseline Feature Delta
Finish P50 [ms] 21.7 21.3 -1.84%
Finish P90 [ms] 31.6 31.2 -1.27%
Finish P99 [ms] 42.1 38.8 -7.84%
Pool Fetch P50 [ms] 11.4 10.5 -7.89%
Pool Fetch P90 [ms] 24.6 24.8 +0.81%
Pool Fetch P99 [ms] 32.4 31.7 -2.16%
Included Tx Exec P50 [ms] - -
Included Tx Exec P90 [ms] - -
Included Tx Exec P99 [ms] - -
Invalid Tx Exec P50 [ms] - -
Invalid Tx Exec P90 [ms] - -
Invalid Tx Exec P99 [ms] - -
Invalid Tx Attempts P50 0.0 0.0 0.00%
Invalid Tx Attempts P90 0.0 0.0 0.00%
Invalid Tx Attempts P99 0.0 0.0 0.00%
Invalid Tx Skips 0 0 0.00%
Nonce Too Low Skips 0 0 0.00%
Serialized Block Size P50 [KiB] 3053.6 3048.9 -0.15%
Serialized Block Size P90 [KiB] 3433.0 3389.4 -1.27%
Serialized Block Size P99 [KiB] 3826.0 3805.1 -0.54%
Fill Overhead P50 [ms] - -
Fill Overhead P90 [ms] - -
Fill Overhead P99 [ms] - -
Fill Idle P50 [ms] 0.0 0.0 0.00%
Fill Idle P90 [ms] 51.0 45.0 -11.76%
Fill Idle P99 [ms] 106.0 116.0 +9.43%

Validator

Metric Baseline Feature Delta
Gas Throughput [Mgas/s] 2363.6 2365.3 +0.07% ⚪ (+/-0.36/floor 0.65)
P50 [ms] 231.8 231.9 +0.04% ⚪ (+/-0.77/floor 1.55)
P90 [ms] 254.9 253.1 -0.71% ⚪ (+/-0.72/floor 1.55)
P99 [ms] 275.3 265.7 -3.49% ✅ (+/-0.69/floor 2.05)

Observability

@tempoxyz-bot tempoxyz-bot marked this pull request as ready for review June 9, 2026 17:09
@tempoxyz-bot

Copy link
Copy Markdown
Contributor Author

derek bench samply run-pairs=1 duration=300 no-slack

@decofe

decofe commented Jun 9, 2026

Copy link
Copy Markdown
Member

cc @tempoxyz-bot

⚪ Benchmark complete: No Difference View job

⚪ Bench Comparison: No Difference

Refs: main vs auto-opt/20260609-concrete-protocol-best
Criteria: 95% run-bootstrap CI must clear floor; cells show delta (+/-CI/floor).

Configuration

  • Derek command: derek bench mode=e2e preset=tip20 duration=300 bloat=100 tps=50000 accounts=1000 max-concurrent-requests=500 baseline=main feature=auto-opt/20260609-concrete-protocol-best baseline-hardfork="" feature-hardfork="" gas-limit=1000000000 run-pairs=1 otlp=true metrics=false no-cache=false force-bloat=false samply
  • Bloat: 100000 MiB
  • Preset: tip20
  • Target TPS: 50000
  • Duration: 300s
  • Run pairs: 1
  • Baseline blocks: 544
  • Feature blocks: 546

Tempo Metrics

Metric Baseline Feature Delta
TPS Mean 20451 20401 -0.24% ⚪
Gas Throughput [Mgas/s] 904.8 902.6 -0.24% ⚪
Block Time Mean [ms] 549.7 548.9 -0.15% ⚪
Block Time P50 [ms] 549.0 549.0 +0.00% ⚪
Block Time P90 [ms] 591.0 590.0 -0.17% ⚪
Block Time P99 [ms] 625.0 621.0 -0.64% ⚪
Serialized Block Size / Tx P50 [B/tx] 251.1 251.1 +0.00% ⚪
Serialized Block Size / Tx P90 [B/tx] 251.1 251.1 +0.00% ⚪
Serialized Block Size / Tx P99 [B/tx] 251.1 251.1 +0.00% ⚪

Builder

Metric Baseline Feature Delta
Gas Throughput [Mgas/s] 2194.4 2198.3 +0.18% ⚪
P50 [ms] 226.3 225.4 -0.40% ⚪
P90 [ms] 241.8 241.9 +0.04% ⚪
P99 [ms] 262.1 262.7 +0.23% ⚪
Builder details
Metric Baseline Feature Delta
Finish P50 [ms] 35.7 35.1 -1.68%
Finish P90 [ms] 49.4 50.3 +1.82%
Finish P99 [ms] 64.6 65.3 +1.08%
Pool Fetch P50 [ms] 8.5 7.8 -8.24%
Pool Fetch P90 [ms] 22.1 21.9 -0.90%
Pool Fetch P99 [ms] 31.0 28.0 -9.68%
Included Tx Exec P50 [ms] - -
Included Tx Exec P90 [ms] - -
Included Tx Exec P99 [ms] - -
Invalid Tx Exec P50 [ms] - -
Invalid Tx Exec P90 [ms] - -
Invalid Tx Exec P99 [ms] - -
Invalid Tx Attempts P50 0.0 0.0 0.00%
Invalid Tx Attempts P90 0.0 0.0 0.00%
Invalid Tx Attempts P99 0.0 0.0 0.00%
Invalid Tx Skips 0 0 0.00%
Nonce Too Low Skips 0 0 0.00%
Serialized Block Size P50 [KiB] 2788.4 2774.9 -0.48%
Serialized Block Size P90 [KiB] 3160.2 3141.6 -0.59%
Serialized Block Size P99 [KiB] 3699.2 3771.1 +1.94%
Fill Overhead P50 [ms] - -
Fill Overhead P90 [ms] - -
Fill Overhead P99 [ms] - -
Fill Idle P50 [ms] 0.0 0.0 0.00%
Fill Idle P90 [ms] 0.0 1.0 n/a
Fill Idle P99 [ms] 82.0 78.0 -4.88%

Validator

Metric Baseline Feature Delta
Gas Throughput [Mgas/s] 2114.9 2121.3 +0.30% ⚪
P50 [ms] 235.0 234.6 -0.17% ⚪
P90 [ms] 264.7 264.5 -0.08% ⚪
P99 [ms] 285.0 284.2 -0.28% ⚪

Observability

Samply Profiles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants