Skip to content

perf: move expired transaction hashes#5569

Open
tempoxyz-bot wants to merge 1 commit into
mainfrom
auto-opt/20260610-move-expired-tx-hashes
Open

perf: move expired transaction hashes#5569
tempoxyz-bot wants to merge 1 commit into
mainfrom
auto-opt/20260610-move-expired-tx-hashes

Conversation

@tempoxyz-bot

Copy link
Copy Markdown
Contributor

Avoid cloning the expired transaction hash vector before pool removal. The maintenance loop no longer needs those hashes after recording the count, so consume the collected vector directly when evicting expired AA transactions.

Avoid cloning the expired transaction hash vector before pool removal. The maintenance loop no longer needs those hashes after recording the count, so consume the collected vector directly when evicting expired AA transactions.
@tempoxyz-bot tempoxyz-bot self-assigned this Jun 10, 2026
@tempoxyz-bot

Copy link
Copy Markdown
Contributor Author

derek bench mode=e2e otlp=false

@decofe

decofe commented Jun 10, 2026

Copy link
Copy Markdown
Member

cc @tempoxyz-bot

✅ Benchmark complete: Improvement View job

✅ Bench Comparison: Improvement

Refs: main vs auto-opt/20260610-move-expired-tx-hashes
Criteria: 95% run-bootstrap CI must clear floor; cells show delta (+/-CI/floor).

Configuration

  • Derek command: derek bench mode=e2e preset=tip20 duration=90 bloat=100 tps=50000 accounts=1000 max-concurrent-requests=500 baseline=main feature=auto-opt/20260610-move-expired-tx-hashes baseline-hardfork="" feature-hardfork="" gas-limit=1000000000 run-pairs=3 otlp=false metrics=false no-cache=false force-bloat=false
  • Bloat: 100000 MiB
  • Preset: tip20
  • Target TPS: 50000
  • Duration: 90s
  • Run pairs: 3
  • Baseline blocks: 489
  • Feature blocks: 483

Tempo Metrics

Metric Baseline Feature Delta
TPS Mean 22011 22271 +1.18% ⚪ (+/-0.75/floor 0.55)
Gas Throughput [Mgas/s] 973.8 985.3 +1.18% ⚪ (+/-0.75/floor 0.50)
Block Time Mean [ms] 551.4 553.8 +0.44% ⚪ (+/-0.41/floor 0.40)
Block Time P50 [ms] 552.0 554.0 +0.36% ⚪ (+/-0.27/floor 0.70)
Block Time P90 [ms] 584.0 585.0 +0.17% ⚪ (+/-0.91/floor 0.70)
Block Time P99 [ms] 607.0 619.0 +1.98% ⚪ (+/-1.51/floor 1.60)
Serialized Block Size / Tx P50 [B/tx] 251.1 251.1 +0.00% ⚪ (+/-0.00/floor 0.70)
Serialized Block Size / Tx P90 [B/tx] 251.1 251.1 +0.00% ⚪ (+/-0.00/floor 0.70)
Serialized Block Size / Tx P99 [B/tx] 251.1 251.1 +0.00% ⚪ (+/-0.00/floor 0.70)

Builder

Metric Baseline Feature Delta
Gas Throughput [Mgas/s] 2332.5 2365.7 +1.42% ✅ (+/-0.68/floor 0.70)
P50 [ms] 228.7 229.3 +0.26% ⚪ (+/-0.32/floor 0.35)
P90 [ms] 242.0 241.6 -0.17% ⚪ (+/-1.49/floor 0.70)
P99 [ms] 301.2 280.2 -6.97% ✅ (+/-3.86/floor 0.95)
Builder details
Metric Baseline Feature Delta
Finish P50 [ms] 23.4 23.6 +0.85%
Finish P90 [ms] 33.4 34.1 +2.10%
Finish P99 [ms] 40.7 40.8 +0.25%
Pool Fetch P50 [ms] 10.4 11.2 +7.69%
Pool Fetch P90 [ms] 24.1 24.9 +3.32%
Pool Fetch P99 [ms] 29.9 32.9 +10.03%
Included Tx Exec P50 [ms] - -
Included Tx Exec P90 [ms] - -
Included Tx Exec P99 [ms] - -
Invalid Tx Exec P50 [ms] - -
Invalid Tx Exec P90 [ms] - -
Invalid Tx Exec P99 [ms] - -
Invalid Tx Attempts P50 0.0 0.0 0.00%
Invalid Tx Attempts P90 0.0 0.0 0.00%
Invalid Tx Attempts P99 0.0 0.0 0.00%
Invalid Tx Skips 0 0 0.00%
Nonce Too Low Skips 0 0 0.00%
Serialized Block Size P50 [KiB] 3017.6 3060.5 +1.42%
Serialized Block Size P90 [KiB] 3418.6 3426.4 +0.23%
Serialized Block Size P99 [KiB] 3960.3 3938.2 -0.56%
Fill Overhead P50 [ms] - -
Fill Overhead P90 [ms] - -
Fill Overhead P99 [ms] - -
Fill Idle P50 [ms] 0.0 0.0 0.00%
Fill Idle P90 [ms] 9.0 2.0 -77.78%
Fill Idle P99 [ms] 146.0 98.0 -32.88%

Validator

Metric Baseline Feature Delta
Gas Throughput [Mgas/s] 2300.3 2305.8 +0.24% ⚪ (+/-0.74/floor 0.65)
P50 [ms] 235.0 238.4 +1.45% ⚪ (+/-1.04/floor 1.55)
P90 [ms] 258.9 258.8 -0.04% ⚪ (+/-0.88/floor 1.55)
P99 [ms] 275.4 281.1 +2.07% ⚪ (+/-3.73/floor 2.05)

Observability

@tempoxyz-bot tempoxyz-bot marked this pull request as ready for review June 10, 2026 06:26
@tempoxyz-bot

Copy link
Copy Markdown
Contributor Author

derek bench samply run-pairs=1 duration=300 no-slack

@decofe

decofe commented Jun 10, 2026

Copy link
Copy Markdown
Member

cc @tempoxyz-bot

🚀 Benchmark started! View job

Status: Running benchmark phase baseline-1 (2/2)...

Config: mode: e2e, preset: tip20, duration: 300s, bloat: 100 GiB, tps: 50000, accounts: 1000, max-concurrent-requests: 500, gas-limit: 1000000000, run-pairs: 1, baseline: main, feature: auto-opt/20260610-move-expired-tx-hashes, txgen-ref: default, samply: enabled, otlp: enabled, valscope: disabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants