test: enable txpool insertion batching with 5ms timeout#5578
Draft
mattsse wants to merge 2 commits into
Draft
Conversation
Patches reth deps to paradigmxyz/reth#20661 and configures the txpool batcher with a 5ms batch timeout and a max batch size of 150.
Contributor
Author
|
derek bench run-pairs=1 |
Member
|
cc @mattsse ⚪ Benchmark complete: No Difference View job ⚪ Bench Comparison: No DifferenceRefs: main vs mattsse/test-txpool-batch-timeout Configuration
Tempo Metrics
Builder
Builder details
Validator
Observability |
Points at mattsse/reth@676d996756, which is the reth PR plus the tempo_tx_batch_metrics timing logs from #5542 and a new sampled log of dispatched batch size and flush trigger (immediate/full/timeout).
Contributor
Author
|
derek bench run-pairs=1 |
Member
|
cc @mattsse ⚪ Benchmark complete: No Difference View job ⚪ Bench Comparison: No DifferenceRefs: main vs mattsse/test-txpool-batch-timeout Configuration
Tempo Metrics
Builder
Builder details
Validator
Observability |
Contributor
Author
|
derek bench samply=true run-pairs=1 |
Member
|
cc @mattsse ⚪ Benchmark complete: No Difference View job ⚪ Bench Comparison: No DifferenceRefs: main vs mattsse/test-txpool-batch-timeout Configuration
Tempo Metrics
Builder
Builder details
Validator
ObservabilitySamply Profiles
|
Contributor
Author
|
derek bench run-pairs=1 feature-args="--txpool.max-batch-size 500 --txpool.batch-timeout 5ms" |
Member
|
cc @mattsse ⚪ Benchmark complete: No Difference View job ⚪ Bench Comparison: No DifferenceRefs: main vs mattsse/test-txpool-batch-timeout Configuration
Tempo Metrics
Builder
Builder details
Validator
Observability |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins reth dependencies to
mattsse/reth@676d996756— paradigmxyz/reth#20661 plus thetempo_tx_batch_metricstiming logs from #5542 and a new sampled info log of every dispatched insertion batch with its size and flush trigger (immediate/full/timeout).Enables the new batch-and-timeout mode: 5ms batch timeout, max batch size lowered from 50000 to 150. Also exposes a
transaction_pool_batch_sizehistogram.For testing under tempo load; not meant to be merged until the reth PR lands and the deps point back at upstream.