fix(precompiles): align stablecoin DEX quotes with execution (TEMPO-DEX7)#5612
Open
crazywriter1 wants to merge 1 commit into
Open
fix(precompiles): align stablecoin DEX quotes with execution (TEMPO-DEX7)#5612crazywriter1 wants to merge 1 commit into
crazywriter1 wants to merge 1 commit into
Conversation
…EX7) Quote functions iterated per-tick while swaps execute per-order, so quotes diverged when multiple orders rested at the same tick. quote_exact_in/out now walk resting orders one-by-one, mirroring fill_orders_exact_in/out. Re-enables TEMPO-DEX7 invariant assertions.
crazywriter1
requested review from
0xKitsune,
0xalpharush,
0xrusowsky,
dankrad,
danrobinson,
horsefacts,
jenpaff,
klkvr,
legion2002,
mattsse and
samczsun
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quote functions iterated per-tick over aggregate liquidity while swaps execute
per-order, so quotes diverged from execution when multiple orders rested at the
same tick (per-order rounding accumulates across order boundaries).
quote_exact_in/quote_exact_outnow walk resting orders one-by-one, mirroringfill_orders_exact_in/fill_orders_exact_out. Re-enables TEMPO-DEX7 invariantassertions.
Verified locally:
cargo test -p tempo-precompiles(919 passed), forgeStablecoinDEXInvariantTest(PASS),StablecoinDEX.t.sol(70 passed).