refactor(consensus): executor owns payload jobs#5625
Open
SuperFluffy wants to merge 4 commits into
Open
Conversation
SuperFluffy
commented
Jun 11, 2026
| proposal | ||
| } | ||
| } | ||
| res.wrap_err("failed creating a proposal") |
Contributor
Author
There was a problem hiding this comment.
fix to not interfere with already verified blocks if for whatever reason the build failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves payload jobs fully into the executor actor and only return the built payload to the application actor. This way, the executor always runs the build to completion even if the proposal is cancelled by the consensus engine, and the application actor can be simplified.