fix(cli): give faucet.enabled arg a unique clap id#5655
Merged
Conversation
FaucetArgs::enabled defaulted to the clap id "enabled", which collides with reth's new JitArgs::enabled when both are flattened into the node command (clap debug_assert panic in tempo node --help, see reth-auto-bump PR #5564 CI). Set an explicit id and update requires/required_if_eq refs.
Member
Author
|
Companion reth PR: paradigmxyz/reth#25183 |
shekhirin
changed the title
klkvr
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
FaucetArgs::enableduses the default clap idenabled. The reth bump in #5564 pulls in reth's newJitArgs, which also has anenabledfield, so both flatten into thenodecommand with the same id and clap's debug assert panics on anytempo nodeinvocation:This is what's failing CLI smoke tests / test (1/2) / test (2/2) on #5564.
Fix
Set an explicit
id = "faucet.enabled"and update the fourrequires/required_if_eqreferences to match. Adds a parse sanity test.No behavior change — flag is still
--faucet.enabled. (Companion reth PR givesJitArgsan explicit id too; either fix alone unblocks #5564.)