Skip to content

docs(tip-1061): specify native multisig accounts - #7242

Draft
joshieDo wants to merge 9 commits into
mainfrom
agent/native-multisig-docs
Draft

docs(tip-1061): specify native multisig accounts#7242
joshieDo wants to merge 9 commits into
mainfrom
agent/native-multisig-docs

Conversation

@joshieDo

@joshieDo joshieDo commented Aug 19, 2026

Copy link
Copy Markdown
Member

Defines native multisig accounts for T11 and adds the corresponding changelog entry. The stacked implementation begins with #7234.

@joshieDo
joshieDo force-pushed the agent/native-multisig-docs branch from 596d269 to f847b91 Compare August 19, 2026 15:33
@joshieDo

Copy link
Copy Markdown
Member Author

cyclops audit fast note="this belongs to the GH stack #7243 and the TIP 1061 is specified in the PR 7242. any bug not introduced by this PR should be clearly marked"

@tempoxyz-bot tempoxyz-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️ Cyclops Review

TIP-1061 is detailed and generally consistent, but two low-severity specification gaps should be resolved before independent implementations target T11.

Reviewer Callouts
  • Primitive sender collision assumption: The design intentionally omits a registry check for primitive signatures that recover to a registered multisig address and treats the approximately 2^80 address-collision attack as out of scope. A human should explicitly accept that account-takeover tradeoff.
  • Pool validation cost: Invalid transactions can pass the claimed sender's fee-affordability check before forcing bounded but expensive multisig verification. Confirm peer scoring or rate limiting handles repeated NativeMultisigValidationFailed submissions.

@joshieDo

Copy link
Copy Markdown
Member Author

cyclops audit fast note="this belongs to the GH stack #7243 and the TIP 1061 is specified in the PR 7242. any bug not introduced by this PR should be clearly marked"

@tempoxyz-bot tempoxyz-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️ Cyclops Review

Two actionable findings were verified in the T11 configurable-accounts specification.

Reviewer Callouts
  • State-dependent intrinsic gas: Ensure pool validation, estimation, block building, and execution use the same journaled block-prefix state and recompute after configuration changes.
  • Direct-frame enforcement: msg.sender == tx.origin does not block DELEGATECALL; require an explicit protocol-frame/depth guard.
  • Configuration storage updates: Clear old owner weight rows before overwriting the owner count or writing new rows.
  • Stateless signer recovery: Audit recover_signer and recover_authority callers so bare multisig encodings are not treated as proof of quorum.
  • Pool/executor consistency: Resolve whether unsupported multisig authorization-list signatures are rejected or skipped and enforce one rule everywhere.
  • Validation work bounds: Consider an explicit pre-verification budget for invalid transactions.
  • Bootstrap version wording: Clarify that the stored version is 0 during bootstrap before a header exists.
  • Configuration events: Include the new version in MultisigConfigUpdated.

@joshieDo

Copy link
Copy Markdown
Member Author

cyclops audit fast note="this belongs to the GH stack #7243 and the TIP 1061 is specified in the PR 7242. any bug not introduced by this PR should be clearly marked"

@tempoxyz-bot tempoxyz-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️ Cyclops Review

TIP-1061 is generally detailed and internally consistent, but one verified Medium gas-accounting issue should be fixed before implementation.

Reviewer Callouts
  • Invalid-transaction validation cost (tips/tip-1061.md:546): Fee affordability precedes owner-approval verification against a statelessly claimed account, allowing expensive junk trees to consume validation work before rejection. Consider checking derivable owner membership and ordering before P256/WebAuthn verification.
  • Non-minimal quorum sets (tips/tip-1061.md:211): Earlier removable signatures can produce multiple transaction hashes for the same authorization. Consider requiring every submitted signature to be necessary for quorum.

Comment thread tips/tip-1061.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants