docs(tip-1061): specify native multisig accounts - #7242
Conversation
596d269 to
f847b91
Compare
|
cyclops audit fast note="this belongs to the GH stack #7243 and the TIP 1061 is specified in the PR 7242. any bug not introduced by this PR should be clearly marked" |
tempoxyz-bot
left a comment
There was a problem hiding this comment.
👁️ Cyclops Review
TIP-1061 is detailed and generally consistent, but two low-severity specification gaps should be resolved before independent implementations target T11.
Reviewer Callouts
- ⚡ Primitive sender collision assumption: The design intentionally omits a registry check for primitive signatures that recover to a registered multisig address and treats the approximately 2^80 address-collision attack as out of scope. A human should explicitly accept that account-takeover tradeoff.
- ⚡ Pool validation cost: Invalid transactions can pass the claimed sender's fee-affordability check before forcing bounded but expensive multisig verification. Confirm peer scoring or rate limiting handles repeated
NativeMultisigValidationFailedsubmissions.
|
cyclops audit fast note="this belongs to the GH stack #7243 and the TIP 1061 is specified in the PR 7242. any bug not introduced by this PR should be clearly marked" |
tempoxyz-bot
left a comment
There was a problem hiding this comment.
👁️ Cyclops Review
Two actionable findings were verified in the T11 configurable-accounts specification.
Reviewer Callouts
- ⚡ State-dependent intrinsic gas: Ensure pool validation, estimation, block building, and execution use the same journaled block-prefix state and recompute after configuration changes.
- ⚡ Direct-frame enforcement:
msg.sender == tx.origindoes not blockDELEGATECALL; require an explicit protocol-frame/depth guard. - ⚡ Configuration storage updates: Clear old owner weight rows before overwriting the owner count or writing new rows.
- ⚡ Stateless signer recovery: Audit
recover_signerandrecover_authoritycallers so bare multisig encodings are not treated as proof of quorum. - ⚡ Pool/executor consistency: Resolve whether unsupported multisig authorization-list signatures are rejected or skipped and enforce one rule everywhere.
- ⚡ Validation work bounds: Consider an explicit pre-verification budget for invalid transactions.
- ⚡ Bootstrap version wording: Clarify that the stored version is
0during bootstrap before a header exists. - ⚡ Configuration events: Include the new version in
MultisigConfigUpdated.
|
cyclops audit fast note="this belongs to the GH stack #7243 and the TIP 1061 is specified in the PR 7242. any bug not introduced by this PR should be clearly marked" |
tempoxyz-bot
left a comment
There was a problem hiding this comment.
👁️ Cyclops Review
TIP-1061 is generally detailed and internally consistent, but one verified Medium gas-accounting issue should be fixed before implementation.
Reviewer Callouts
- ⚡ Invalid-transaction validation cost (
tips/tip-1061.md:546): Fee affordability precedes owner-approval verification against a statelessly claimed account, allowing expensive junk trees to consume validation work before rejection. Consider checking derivable owner membership and ordering before P256/WebAuthn verification. - ⚡ Non-minimal quorum sets (
tips/tip-1061.md:211): Earlier removable signatures can produce multiple transaction hashes for the same authorization. Consider requiring every submitted signature to be necessary for quorum.
Defines native multisig accounts for T11 and adds the corresponding changelog entry. The stacked implementation begins with #7234.