Conversation
Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com>
decofe
marked this pull request as ready for review
September 16, 2026 12:47
decofe
requested review from
0xKitsune,
0xrusowsky,
adityapk00,
klkvr,
legion2002 and
mattsse
as code owners
September 16, 2026 12:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Derive the L1 portal address from the zone ID encoded in genesis using Tempo's
zone_factory::portal_address, for node services (including the checker), HTTP-backed re-execution, and the offline EVM fallback. Node startup no longer requires--l1.portal-address/L1_PORTAL_ADDRESS; supplied values are deprecated consistency checks and cannot override genesis.Remove the explicit address from dev, Justfile, and benchmark node launchers. This enables infra to remove
l1PortalAddressafter rolling out the updated node; operator schemas and infra manifests are outside this PR. Direct deposit/admin tooling still accepts a target portal, and legacy EOA-deployed portals cannot be selected through node configuration.Validation: all four CI test shards passed (920 tests), including the new mainnet/Moderato/dev derivation and offline EVM regressions. The network-chaos high-L1-latency test passed on retry. Clippy and Rust formatting passed; local whitespace and benchmark shell syntax checks also passed.
Prompted by: @shekhirin