feat(xtask): add forced withdrawal command and protocol docs - #1473
Draft
adityapk00 wants to merge 3 commits into
Draft
adityapk00 wants to merge 3 commits into
adityapk00 wants to merge 3 commits into
Conversation
adityapk00
added this pull request to stack #1456
September 17, 2026 19:30
Collaborator
Author
|
cyclops audit fast |
|
cc @adityapk00 Cyclops audit event published. View workflow run Config: config: |
tempoxyz-bot
left a comment
There was a problem hiding this comment.
👁️ Cyclops Review
This PR adds an xtask forced-withdraw command and documentation for TIP-1012 forced withdrawals. One actionable issue was found: the CLI trusts a user-supplied portal address for both validation and the compensation approval amount, which can expose the fee payer's selected TIP-20 balance when --approve is used.
Reviewer Callouts
- ⚡ Forced-exit crypto canonicalization: Existing forced-exit crypto paths allow two low-impact alternate encodings: ECIES HKDF does not bind the ephemeral public-key parity byte, and secp256k1 recovery-byte normalization accepts multiple encodings for the same signature. Nonce/domain binding prevents replay or fund loss today, but maintainers may want to canonicalize while the spec is being updated.
- ⚡ Witness confidentiality assumption: Forced-exit processing relies on
advanceTempodecryption witnesses being kept as sensitive as plaintext authorizations. This is a base-design assumption rather than a PR regression, but it is worth confirming that operational visibility of zone block bodies/witnesses matches that threat model.
adityapk00
force-pushed
the
codex/forced-withdraw-xtask
branch
from
September 18, 2026 13:45
20e0c8a to
687ca61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
tempo-xtask forced-withdrawto submit an encrypted, root-authorized full-balance withdrawal using only Tempo L1 RPC. Supports a separate fee payer, optional compensation approval, and waiting for settled inbox progress; waiting confirms consumption, not successful payout.Updates the exit-hatch README and protocol spec with authorization and encryption, weighted admission, execution and rollback rules, ordinary settlement, and delivery/recovery. Documents that production activation and enforcing proof verification remain follow-ups.
Stacked on #1461 (
codex/exit-hatch-execution-settlement). This PR contains only the CLI and documentation changes above that implementation.Validation:
git diff --checkpassed; spec ABI excerpts were checked against the contract interface. The squashed commit has an identical tree to the original branch tip. Tests were not rerun for this history-only squash.