Pypi description load from README#1057
Conversation
kenya-sk
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates image URLs in README.md to absolute paths and modifies release/setup.py to dynamically load the long description from the README file. Feedback suggests refactoring setup.py to eliminate duplicated path resolution logic and recommends dynamically transforming relative image paths during the build process to maintain repository portability.
mhucka
changed the title
…into pypi-description
…ypi-description
|
@mhucka |
mhucka
left a comment
mhucka
left a comment
There was a problem hiding this comment.
Thank you for working on this!
I think there may be a small error in which README.md file gets used. Also, I will do a quick PR to replace the relative path to the logo image in the top-level README.md file so that it's an absolute path, and this will avoid the need for the regex-based replacement implemented in this PR.
…ypi-description
2 participants
Use the project
README.mdas the PyPI long description instead of the hardcoded module docstring inrelease/setup.py(Issue #1055 ).Keep image paths in
README.mdrelative for repository portability, and rewrite them to absolute GitHub raw URLs only when generating the PyPI long description so they continue to render correctly on PyPI.