chore (vicinae): add layer-shell-qt runtime dependency#12589
chore (vicinae): add layer-shell-qt runtime dependency#12589aamirsahmad wants to merge 2 commits into
Conversation
Vicinae imports `org.kde.layershell` as a QML plugin at runtime, which RPM's automatic dependency generator does not detect (the module isn't dynamically linked from the binary). Without layer-shell-qt installed, the QML window component fails to load and the launcher window never appears — meanwhile the server reports itself as "open", desyncing UX from reality. Bumps Release to 2 and adds a %changelog entry. Refs: terrapkg#12588 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Aamir Ahmad <aamirahmad@outlook.com>
|
just to confirm, did you start the server with the app menu icon before trying vicinae toggle? i've found it not starting can sometimes be cause by that otherwise this pr looks good |
|
Yes —
So the launch path (menu icon vs |
|
Is this tested working? |
Co-authored-by: Owen Zimmerman <123591347+Owen-sz@users.noreply.github.com> Signed-off-by: Aamir Ahmad <aamirahmad@outlook.com>
|
The runtime dependency is confirmed working — per the log above, without I also parsed the modified spec with I haven't done a full mock/anda rebuild locally, so I can't claim end-to-end install testing of the rebuilt RPM — but the change is just a declarative one-line |
|
since you have a test plan I guess we can merge after you have finished and are ready note that we do not accept untested patches according to our policies: http://docs.terrapkg.com/contributing/policies/#submission-policy |
Summary
Requires: layer-shell-qttoanda/system/vicinae/vicinae.spec.Releasefrom1to2and adds a%changelogentry.Why
Vicinae imports
org.kde.layershellas a QML plugin at runtime — not as a linked shared library. RPM's automatic dependency generator only inspects the binary'sNEEDEDentries, so the dependency onlayer-shell-qtis invisible to it and never lands inRequires.Without
layer-shell-qtinstalled, the launcher silently fails:The window is never created, but
vicinae-serverstill marks itself as "open" — sovicinae openreportsFailed to open: Already openedand the user sees nothing. Reported in #12588.The build side already has
BuildRequires: cmake(LayerShellQt), so no build change is needed; only the missing runtimeRequiresis added.The Vicinae upstream Copr packaging hit the same bug and resolved it the same way — see vicinaehq/vicinae#1388.
Test plan
anda build -c terra-rawhide-x86_64 anda/system/vicinaelayer-shell-qtpre-installed:sudo dnf install ./vicinae-0.21.1-2.*.rpm— verifylayer-shell-qtis pulled in automaticallyrpm -q --requires vicinae | grep layer-shell-qtreturns the depsystemctl --user start vicinae && vicinae toggle— window appears on first invocationCloses #12588