Skip to content

fix: lcp on directory prefix #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XiangYyang merged 1 commit into from
Apr 27, 2026
Merged

fix: lcp on directory prefix #190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 19 additions & 10 deletions src/kicanvas/services/vfs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,20 +352,29 @@ export class DragAndDropFileSystem extends LocalFileSystemBase {
}

private static lcp(str: string[]): string {
const beg = str[0] ?? "";
return str.reduce((common, path) => {
let i = 0;
if (str.length === 0) {
return "";
}

while (
i < common.length &&
i < path.length &&
common[i] === path[i]
) {
// split dirname only
const str_arr = str.map((s) =>
s.split("/").filter(Boolean).slice(0, -1),
);

const fst = str_arr[0]!;
let p_len = fst.length;
for (const s of str_arr.slice(1)) {
let i = 0;
while (i < p_len && i < s.length && fst[i] === s[i]) {
i += 1;
}
p_len = i;
if (p_len === 0) {
break;
}
}

return common.slice(0, i);
}, beg);
return fst.slice(0, p_len).join("/");
}

private static async load(entry: FileSystemFileEntry): Promise<File> {
Expand Down
Loading