Port Netflix/Hystrix#1976 remove canceled timer tasks#2
Open
amrith92 wants to merge 1 commit into
Open
Conversation
|
Looks good as a faithful upstream port. Only compatibility check: Focused verification is sufficient for this scoped port. A regression test or explicit upstream reference would be nice, not blocking. |
![tully-review[bot]](https://avatars.githubusercontent.com/u/11135641?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports Netflix#1976 into this fork.\n\nThe upstream change enables ScheduledThreadPoolExecutor#setRemoveOnCancelPolicy(true) for HystrixTimer so canceled timeout tasks are removed from the scheduler queue instead of remaining until their delay elapses.\n\nUpstream reference: https://github.com/Netflix/Hystrix/pull/1976\nOriginal commit: 2f4520d\n\nVerification:\n- PASS: JAVA_HOME=/Users/amrith/.sdkman/candidates/java/17.0.6-tem ./gradlew :hystrix-core:test --tests com.netflix.hystrix.util.HystrixTimerTest --no-daemon\n- NOTE: ./gradlew :hystrix-core:test --no-daemon failed under Java 21 before compilation because Gradle/Groovy cannot parse class file major version 65. Re-run under Java 17 progressed into tests but hung in the broader test task, so it was stopped and replaced with the focused HystrixTimer test above.\n