Skip to content

Update MetaMask icon SVG#2395

Merged
0xFirekeeper merged 2 commits into
thirdweb-dev:developfrom
shahbaz17:develop
May 28, 2026
Merged

Update MetaMask icon SVG#2395
0xFirekeeper merged 2 commits into
thirdweb-dev:developfrom
shahbaz17:develop

Conversation

@shahbaz17
Copy link
Copy Markdown
Contributor

@shahbaz17 shahbaz17 commented May 28, 2026

Description

Replace the embedded SVG string in packages/metamask/src/icon.ts with a new MetaMask SVG.

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Tests with demo app (SDK)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Summary by CodeRabbit

  • Style
    • Replaced the app icon SVG with a refreshed artwork using a simplified path-based design.
    • Adjusted SVG sizing and rendering attributes for crisper display and more consistent appearance across layouts.

Review Change Stack

Replace the embedded SVG string in packages/metamask/src/icon.ts with a new MetaMask SVG.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b2d3ba9f-feee-4165-ba3a-7951c197c25f

📥 Commits

Reviewing files that changed from the base of the PR and between d7dcf10 and a70ab07.

📒 Files selected for processing (1)
  • packages/metamask/src/icon.ts
✅ Files skipped from review due to trivial changes (1)
  • packages/metamask/src/icon.ts

Walkthrough

This PR replaces the MetaMask SVG asset exported from packages/metamask/src/icon.ts, rewriting the SVG header, viewBox/style sizing, and internal markup from polygon/CSS to a new path-based set of shapes; the export signature remains unchanged.

Changes

MetaMask Icon Asset Update

Layer / File(s) Summary
MetaMask Icon SVG Replacement
packages/metamask/src/icon.ts
The embedded SVG asset is replaced from a polygon/CSS-styled structure to a path-based SVG with updated header attributes, viewBox/style sizing, geometry, and fill colors.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description includes a concise explanation of the change, but the associated checklist items remain unchecked, indicating the PR is not ready for review as per the template requirements. Complete the pre-review checklist items (version increment, local testing, yarn check-all, CI checks, etc.) before submitting for review, or mark completed items as checked.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change—updating the MetaMask icon SVG file—and is directly related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Update packages/metamask/src/icon.ts to use `<?xml version="1.0" encoding="utf-8"?>` for the exported SVG string and remove the Adobe Illustrator generator comment. This ensures consistent UTF-8 character encoding and removes unnecessary metadata from the SVG export.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

Actionable comments posted: 0

1 similar comment
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

Actionable comments posted: 0

@0xFirekeeper 0xFirekeeper merged commit 03b25b0 into thirdweb-dev:develop May 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants