Skip to content

Fix playback of MP3 files #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thp merged 2 commits into from
Jan 23, 2026
Merged

Fix playback of MP3 files #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ab5afc
Fix debug output formatting (sample_file vs self->filename)
thp Jan 23, 2026
6d3416b
Fix preview of MP3 files using mpg123
thp Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ The format mostly follows [Keep a Changelog](https://keepachangelog.com/en/1.0.0
### Fixed

* Importing of track breaks via CUE file now works with any well formatted CUE file
* mpg123-based MP3 playback live preview fix (mono vs stereo channel count bug)

## [0.16] -- 2022-12-20

Expand Down
4 changes: 2 additions & 2 deletions src/format_mp3.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ mp3_write_file(OpenedAudioFile *self, const char *output_filename, unsigned long
report_progress(1.0, report_progress_user_data);

#if defined(WAVBREAKER_MP3_DEBUG)
g_debug("Wrote %d MP3 frames from '%s' to '%s'", frames_written, sample_file, output_filename);
g_debug("Wrote %d MP3 frames from '%s' to '%s'", frames_written, self->filename, output_filename);
#endif /* WAVBREAKER_MP3_DEBUG */

fclose(output_file);
Expand Down Expand Up @@ -307,7 +307,7 @@ mp3_open_file(const FormatModule *self, const char *filename, char **error_messa

mpg123_format_none(mp3->mpg123);
if (mpg123_format(mp3->mpg123, si->samplesPerSec,
(si->channels == 1) ? MPG123_STEREO : MPG123_MONO,
(si->channels == 1) ? MPG123_MONO : MPG123_STEREO,
MPG123_ENC_SIGNED_16) != MPG123_OK) {
format_module_set_error_message(error_message, "Failed to set mpg123 format");
goto error;
Expand Down
Loading