Skip to content

ci: add zizmor pre-commit hook and harden GitHub Actions workflows #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thrix-bot wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ci: add zizmor pre-commit hook and harden GitHub Actions workflows #40

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a5cbd3f
ci: add `zizmor` pre-commit hook and harden GitHub Actions workflows
thrix Apr 10, 2026
d5deb47
ci: use GitHub environment for secrets in container build workflow
thrix Apr 10, 2026
de92d9d
Merge branch 'main' into ci/add-zizmor-and-pin-actions
thrix May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/container.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions .github/workflows/container.yml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
plan: /tmt/build/rawhide
{% raw %}
container:
image: quay.io/testing-farm/cli:latest
image: quay.io/testing-farm/cli:latest # zizmor: ignore[unpinned-images]

steps:
- name: Compute image tag
Expand All @@ -43,8 +43,8 @@ jobs:

- name: Schedule build via Testing Farm
env:
TESTING_FARM_API_TOKEN: ${{ secrets.TESTING_FARM_API_TOKEN }}
GHCR_TOKEN: ${{ secrets.GHCR_TOKEN }}
TESTING_FARM_API_TOKEN: ${{ secrets.TESTING_FARM_API_TOKEN }} # zizmor: ignore[secrets-outside-env]
GHCR_TOKEN: ${{ secrets.GHCR_TOKEN }} # zizmor: ignore[secrets-outside-env]
REPO_OWNER: ${{ github.repository_owner }}
GIT_SHA: ${{ github.event.pull_request.head.sha || github.sha }}
TARGET_IMAGE: ghcr.io/thrix/nix-toolbox:${{ steps.tag.outputs.value }}
Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/mkdocs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,12 @@ jobs:

steps:
- name: Checkout repo
uses: actions/checkout@v6
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
with:
persist-credentials: false

- name: Set up Python
uses: actions/setup-python@v6
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6
with:
python-version: '3.14'

Expand All @@ -44,7 +46,7 @@ jobs:
fi

- name: Deploy to GitHub Pages
uses: peaceiris/actions-gh-pages@v4
uses: peaceiris/actions-gh-pages@4f9cc6602d3f66b9c108549d475ec49e8ef4d45e # v4
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
publish_dir: ./site
Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/refresh-build-fmf.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,12 @@ jobs:

steps:
- name: Checkout repo
uses: actions/checkout@v6
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
with:
persist-credentials: false

- name: Set up Python
uses: actions/setup-python@v5
uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5
with:
python-version: '3.13'

Expand All @@ -33,7 +35,7 @@ jobs:
run: make generate/build-fmf

- name: Create pull request if changed
uses: peter-evans/create-pull-request@v7
uses: peter-evans/create-pull-request@22a9089034f40e5a961c8808d113e2c98fb63676 # v7
with:
commit-message: |
ci: regenerate configs and docs for current Fedora releases
Expand Down
15 changes: 10 additions & 5 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
---
repos:
- repo: https://github.com/shellcheck-py/shellcheck-py
rev: v0.11.0.1
rev: 745eface02aef23e168a8afb6b5737818efbea95 # v0.11.0.1
hooks:
- id: shellcheck

- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v6.0.0
rev: 3e8a8703264a2f4a69428a0aa4dcb512790b2c8c # v6.0.0
hooks:
- id: check-added-large-files
- id: check-ast
Expand All @@ -29,12 +29,12 @@ repos:
- id: trailing-whitespace

- repo: https://github.com/gitleaks/gitleaks
rev: v8.30.1
rev: 83d9cd684c87d95d656c1458ef04895a7f1cbd8e # v8.30.1
hooks:
- id: gitleaks

- repo: https://github.com/igorshubovych/markdownlint-cli
rev: v0.48.0
rev: e72a3ca1632f0b11a07d171449fe447a7ff6795e # v0.48.0
hooks:
- id: markdownlint
args:
Expand All @@ -47,6 +47,11 @@ repos:
- sentences-per-line

- repo: https://github.com/codespell-project/codespell
rev: v2.4.2
rev: 2ccb47ff45ad361a21071a7eedda4c37e6ae8c5a # v2.4.2
hooks:
- id: codespell

- repo: https://github.com/woodruffw/zizmor-pre-commit
rev: ea2eb407b4cbce87cf0d502f36578950494f5ac9 # v1.23.1
hooks:
- id: zizmor
Loading