remove platform specific bits from Todd's cascading import - #97
Open
ewollesen wants to merge 1 commit into
Open
Conversation
- don't use SaramaRunner and SaramaRunnerConfig They were intended to mesh with platform abstractions and configuration. They don't generalize well to clinic-worker's needs. - add an fx-specific adapter for clinic-worker This makes use of a newly written non-blocking adapter added to go-common that better generalizes to fx's lifecycle management. It looks like a big expansion of code, but that's only because it's doing some of what was hidden by SaramaRunner previously. - modify to use go-common's asyncevents.CascadingSaramaEventsManager This freshly re-worked abstraction should service Care Partner Alerts (it's original intent) and other future users equally well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also: tidepool-org/go-common#79 on which this builds.
don't use SaramaRunner and SaramaRunnerConfig
They were intended to mesh with platform abstractions and configuration. They don't generalize well to clinic-worker's needs.
add an fx-specific adapter for clinic-worker
This makes use of a newly written non-blocking adapter added to go-common that better generalizes to fx's lifecycle management.
It looks like a big expansion of code, but that's only because it's doing some of what was hidden by SaramaRunner previously.
modify to use go-common's asyncevents.CascadingSaramaEventsManager
This freshly re-worked abstraction should service Care Partner Alerts (it's original intent) and other future users equally well.