Repository navigation
Fix mouse event coordinates on high-DPI displays - #169
Merged
Merged
Conversation
offsetX/Y are CSS pixels, but hit-testing operates in framebuffer coords (OnResize reports p.fbWidth/p.fbHeight). Multiply canvasPos by p.dpr so click targets land where the user sees them. Re-read devicePixelRatio in the resize handler so runtime DPR changes (monitor switch, browser zoom) update fbWidth/fbHeight correctly. https://claude.ai/code/session_011ES5S83Xfs7uwCjPbkBnj8
|
Thank you for your contribution to lux! Before we can merge this pull request, we need you to agree to the Contributor License Agreement (CLA). It grants the Project the rights needed to distribute your contribution under both the noncommercial and commercial licenses. I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Repository owner
unlocked this conversation
Apr 21, 2026
Owner
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes mouse event coordinate handling on high-DPI displays (devices with
devicePixelRatio > 1). Previously, mouse coordinates were not being scaled by the device pixel ratio, causing clicks and mouse movements to be misaligned with rendered content on high-DPI screens.The changes:
devicePixelRatiofrom the window object during resize events and store it inp.dproffsetXandoffsetY) by the device pixel ratio in thecanvasPosmethodThis ensures that mouse input coordinates are properly mapped to the canvas coordinate system on all display densities.
Type of change
Testing
go build -tags nogui ./...passesgo vet -tags nogui ./...passesChecklist
CONTRIBUTING.mddocs/,README.md, inline comments)Fixes #
https://claude.ai/code/session_011ES5S83Xfs7uwCjPbkBnj8