Repository navigation
ci(cla): allowlist claude+bots so signatures/v1/cla.json actually updates - #171
Merged
Merged
Conversation
Fix: signatures/v1/cla.json in lux-cla-signatures never got updated after signing PRs that contained Claude Code-authored commits. Root cause: PR commits show up as `Claude <noreply@anthropic.com>`, which GitHub maps to the `claude` GitHub account (id 81847). The CLA allowlist only contained `timzifer,dependabot[bot]`, so `claude` was treated as an unsigned committer. When timzifer commented the sign phrase, CLA Assistant Lite did not persist a signature because timzifer is already allowlisted (not an unsigned committer), and `claude` is a no-reply bot account that cannot post the sign comment itself. Net effect: file created once, never updated. Changes: - `.github/workflows/cla.yml`: add `claude` and `*[bot]` to the allowlist so Claude Code-authored and bot-authored commits no longer block merges. - `CLAUDE.md`: document the `timzifer` git identity override for future Claude Code sessions so commits land under the allowlisted account in the first place and real contributors' signatures remain visible in the signatures file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix:
signatures/v1/cla.jsonintimzifer/lux-cla-signaturesis created once but never updated, even after commenting the sign phrase on a PR.Root cause
PR commits produced in Claude Code sessions are authored as
Claude <noreply@anthropic.com>. GitHub maps that to the accountclaude(id81847), nottimzifer. The CLA allowlist only containedtimzifer,dependabot[bot], soclaudewas treated as an unsigned committer.When
timziferthen postsI have read the CLA Document and I hereby sign the CLA, CLA Assistant Lite does not persist a signature:timziferis already allowlisted, so the action considers them "not an unsigned committer" and skips the write.claudeis a no-reply bot account that cannot itself post the sign comment.Net effect: the signatures file is created on the first run and then never updated.
Evidence:
a257a043— authorclaude(id 81847).issue_commentCLA Assistant run on web: Fix canvas sizing with CSS-driven layout and container resizes #170 after the sign comment completes with conclusionfailureand no bot follow-up comment.e8002410on the (merged) branchclaude/scale-canvas-dpr-ahnfsalready diagnosed this but never landed inmain.Changes
.github/workflows/cla.yml: extend allowlist totimzifer,dependabot[bot],claude,*[bot]so Claude Code- and bot-authored commits don't block merges.CLAUDE.md(new): document the requireduser.name=timzifer/user.email=6703801+timzifer@users.noreply.github.comoverride for future Claude Code sessions, so commits land under the allowlisted identity and the signatures file remains accurate for real outside contributors.Test plan
signatures/v1/cla.json.dependabot[bot]PRs continue to pass.