-
Notifications
You must be signed in to change notification settings - Fork 6
feat(tui): kill watched harnesses with confirmation #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
e2d04d0
feat(tui): kill watched harnesses with confirmation
senamakel 1af5188
Merge remote-tracking branch 'refs/remotes/upstream/main' into pr/141
senamakel d193928
fix(tui): resolve kill target from current selection
senamakel 52fc942
feat(daemon): distinguish task termination from interrupt
senamakel af9fe0c
test(e2e_screen_stream): wait for killed session to stop
senamakel d242b6f
fix(tests): clone session id before reporting
senamakel f3dd305
feat(sdk): advertise screen kill capability and correlate kills
senamakel e1bc687
fix(hub): require correlation id for task kills
senamakel 4fda36f
test: add correlation_id to Kill messages in tests
senamakel 264ce05
test: cover screen kill capability and stale dispatch handling
senamakel 41ce380
style: format attribute and condition for readability
senamakel e4ae395
fix(daemon): clarify terminate_task correlation semantics
senamakel 026dd21
fix(daemon): stop probe from waiting on task slot permit
senamakel 697445c
feat(hub): cache worker capabilities for kill checks
senamakel 742878b
feat(daemon): gate screen-kill capability on router installation
senamakel 8aa29eb
fix(sdk): add AtomicBool to daemon runtime imports
senamakel 58a3d0f
fix(runner): scope kill support to the dispatch that negotiated it
senamakel 61ca686
Merge remote-tracking branch 'upstream/main' into pr/141
senamakel 345c762
feat(hub): negotiate screen-kill capability per task run
senamakel b346590
fix(runner): wait for contact acceptance before starting task
senamakel 8f6e9d0
fix(runner): clean up stale abort registrations on abort
senamakel c31d785
test: reorder test module declarations alphabetically
senamakel 2adb8c0
test(tinyplace): move budget window default test to capabilities
senamakel 5e69830
fix(hub): reuse abort signal from capability negotiation
senamakel da5af4f
fix(runner): delegate run to run_inner
senamakel 218c4ed
fix(pty): stop turn only when orchestrator still owns session
senamakel 701c292
fix(hub): return abort handle even when capability negotiation fails
senamakel c62e32a
fix(control_socket): negotiate screen kill before dispatch
senamakel 04d256e
fix(hub): pass visible task id through negotiated runs
senamakel c2b1cfc
refactor(control_socket): simplify run_negotiated call
senamakel 35072e9
refactor(keys): extract kill arming and require unmodified y
senamakel dd64e13
fix(hub): use wire task id when killing screen tasks
senamakel c3182ba
fix(tui): ignore non-running tasks in input routing
senamakel 3f92d04
fix(keys): restrict kill command to running tasks
senamakel 48b27e1
test(tui): use running-task fixture in kill confirmation tests
senamakel 5944937
fix(tests): update TuiEvent import path in test helper
senamakel c755bfe
test(tui): update running task fixture setup
senamakel b55896b
Merge remote-tracking branch 'upstream/main' into pr/141
senamakel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fresh evidence after the cold-probe fix: when an earlier capability request has spawned the background
get_capabilities, that function holdsinner.capabilitiesacross the inference, so a later pre-dispatch request blocks on this.lock().awaitbefore it can enter the static-response branch. If inference exceeds the runner's three 12-second acknowledgement windows, the task is dispatched withscreen_kill: false; thus a backend capability probe immediately followed by a task can still make that task permanently unkillable. Track the in-progress probe separately or otherwise return the static control facts without waiting on this mutex.Useful? React with 👍 / 👎.