-
Notifications
You must be signed in to change notification settings - Fork 5
feat(companion): expose relay/tab handles for embedding hosts (OpenHuman wiring) #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
graycyrus
wants to merge
2
commits into
feat/chrome-extension
Choose a base branch
from
oh/chrome-ext-relay
base: feat/chrome-extension
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bind_run/cancel_workflowasymmetry for external runsExternal runs registered via
bind_runare never inserted intoself.inner.runs, socancel_workflowreturnsfalseimmediately for them. If an OpenHuman workflow is running a browser graph and the host wants to abort mid-flight (e.g., on user request), callingcancel_workflowwill silently do nothing — neither the CancellationToken signal nor the relay-sidecancel_run(which dispatchesBrowserCancelto the extension and resolves the in-flightServerInner.pendingsenders) will fire.The in-flight browser actions will keep executing on the extension side and will only settle when they timeout or the extension responds, leaving
RelayState.pendingandServerInner.pendingoccupied in the meantime. At minimum the doc comment oncancel_workflowshould note it is for native runs only, andbind_run/unbind_runshould document that callers are responsible for cancelling in-flight actions before unbinding.