Repository navigation
Fix descendant completion regression racing successful cleanup - #216
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The linux-arm64 CI job on #215 caught a test race: fast legacy-family cleanup correctly killed/reaped the escaped child before the parent test's Getpgid call.
Publish PID/process-group proof atomically inside the escaped child and let the fast fixture parent exit once that proof exists. The assertion no longer requires a successfully cleaned-up process to remain alive. No production behavior changes; non-fast cases still assert tracked-descendant termination and single mode still asserts survival.
Validation: completion regression repeated 20 times; full guestinit race suite passes.