Skip to content

fix(daemon): write PID and install signal handlers in foreground mode #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Maple-Aikon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(daemon): write PID and install signal handlers in foreground mode #554

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion code_review_graph/daemon_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

def _handle_start(args: argparse.Namespace) -> None:
"""Start the daemon process."""
from .daemon import WatchDaemon, is_daemon_running, load_config
from .daemon import WatchDaemon, is_daemon_running, load_config, write_pid

if is_daemon_running():
print("Error: Daemon is already running.")
Expand All @@ -42,6 +42,9 @@ def _handle_start(args: argparse.Namespace) -> None:

if not args.foreground:
daemon.daemonize()
else:
write_pid()
daemon._setup_signal_handlers()

daemon.run_forever()

Expand Down