Skip to content

Update JDK version from 1.8 to 17 #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mpsijm wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update JDK version from 1.8 to 17 #1088

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
10ce0a0
Update JDK version from 1.8 to 1.16
Mobmaker55 Jul 7, 2021
812932f
Update JDK version from 1.16 to 17 + update maven-shade-plugin
mpsijm Jan 7, 2022
a24a8ac
pom.xml: Update maven-shade-plugin to 3.3.0
mpsijm Apr 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
language: java
jdk:
- openjdk8
- openjdk17
addons:
apt:
packages:
Expand Down
10 changes: 8 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
<version>3.2.4</version>
<version>3.3.0-SNAPSHOT</version>

@MattSturgeon MattSturgeon Apr 20, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should just be 3.3.0, no -SNAPSHOT

@mpsijm mpsijm Apr 20, 2022

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the heads-up! 😄 That version seems to have been released about a month ago 🙂

<executions>
<execution>
<phase>package</phase>
Expand Down Expand Up @@ -125,4 +125,10 @@
<type>maven-plugin</type>
</dependency>
</dependencies>
</project>
<pluginRepositories>
<pluginRepository>
<id>maven-snapshots</id>
<url>https://repository.apache.org/content/repositories/snapshots/</url>
</pluginRepository>
</pluginRepositories>
</project>
4 changes: 2 additions & 2 deletions src/main/resources/amidst/metadata.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
project.build.sourceEncoding=UTF-8
amidst.build.jdk.version=1.8
amidst.build.filename=amidst-v4-7
amidst.build.jdk.version=17
amidst.build.filename=amidst-v4-7-java17

amidst.version.major=4
amidst.version.minor=7
Expand Down
4 changes: 2 additions & 2 deletions travis-ci/wrapper-for-windows/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<plugin>
<groupId>com.akathist.maven.plugins.launch4j</groupId>
<artifactId>launch4j-maven-plugin</artifactId>
<version>1.7.8</version>
<version>2.1.1</version>
<executions>
<execution>
<id>launch4j</id>
Expand Down Expand Up @@ -75,4 +75,4 @@
<scope>provided</scope>
</dependency>
</dependencies>
</project>
</project>