Skip to content

docs(useImpressionRef): mark rootMargin as optional - #569

Merged
hyesungoh merged 2 commits into
toss:mainfrom
GamjaIsMine02:codex/docs-use-impression-ref-root-margin
Oct 19, 2026
Merged

hyesungoh merged 2 commits into
toss:mainfrom
GamjaIsMine02:codex/docs-use-impression-ref-root-margin

Conversation

@GamjaIsMine02

Copy link
Copy Markdown
Contributor

Overview

The API docs mark useImpressionRef's rootMargin option as required, although UseImpressionRefOptions uses Partial and already permits omitting it.

Mark the option as optional in JSDoc, regenerate the English page and agent skill reference, and update the ko, ja, zh-Hans, and es pages. Add a patch changeset for the public JSDoc correction.

Runtime behavior and the public TypeScript signature are unchanged.

Validation

Documentation checks and the existing useImpressionRef tests pass (12 tests).

@changeset-bot

changeset-bot Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5fa6eb8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-simplikit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter

codecov-commenter commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d8e8147) to head (5fa6eb8).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #569   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           69        69           
  Lines         2281      2281           
  Branches       737       737           
=========================================
  Hits          2281      2281           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hyesungoh hyesungoh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this 👍 👍

@hyesungoh
hyesungoh merged commit 8ead31d into toss:main Oct 19, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants