Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 5fa6eb8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #569 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 69 69
Lines 2281 2281
Branches 737 737
=========================================
Hits 2281 2281 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The API docs mark
useImpressionRef'srootMarginoption as required, althoughUseImpressionRefOptionsusesPartialand already permits omitting it.Mark the option as optional in JSDoc, regenerate the English page and agent skill reference, and update the ko, ja, zh-Hans, and es pages. Add a patch changeset for the public JSDoc correction.
Runtime behavior and the public TypeScript signature are unchanged.
Validation
Documentation checks and the existing
useImpressionReftests pass (12 tests).