Repository navigation
Conversation
Use Client Hints when available and keep legacy UA/platform fallbacks, including the existing iPadOS touch heuristic. Closes toss#356.
🦋 Changeset detectedLatest commit: 733a3bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
Thanks to your contribution. please check closed issue comment #356 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #573 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 69 72 +3
Lines 2281 2306 +25
Branches 737 752 +15
=========================================
+ Hits 2281 2306 +25 🚀 New features to boost your workflow:
|
Member
|
[fyi] But even if we went ahead with that issue, this PR would only cover part of it, so |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testUserAgent/testPlatformhelpers that prefernavigator.userAgentDataand fall back to legacynavigator.platform/navigator.userAgentisIOSandisAndroidto those helpers while keeping the publicuserAgent?: stringAPI, SSR behavior, and the iPadOS (Mac+maxTouchPoints) heuristicko/ja/zh-Hans/es), and the agent skill referencesCloses #356
Out of scope
New public utils (
isMac,isIPhone,isIPad, …) are left for a follow-up so this PR stays reviewable.Test plan
vitest runfor_internal/platform,isIOS,isAndroid(29 tests)yarn typecheckinpackages/react-simplikitMade with Cursor