fix(watsonx): use configured API endpoint - #4382
Draft
LuisFigueroaG wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
us-southendpoint for every requestcredentials.urlobjects and legacywml_credentials["url"]mappingswatsonx.api_basewhen the SDK does not expose a trustworthy endpointRoot cause
The instrumentation always set
watsonx.api_basetohttps://us-south.ml.cloud.ibm.com, regardless of the region or custom/on-prem endpoint used by the Watsonx client.There was also a signature mismatch in the input handler:
_handle_inputdeclared an unusedresponse_counterparameter, while its caller did not provide one. The instrumentation's defensive decorator swallowed thatTypeError, preventing API and other input attributes from being recorded. Removing the unused parameter makes the endpoint resolution effective.The endpoint is now resolved from explicit constructor credentials or API clients first, then from the current and legacy client shapes available on the model instance. If none provides a valid URL, no API base attribute is emitted rather than reporting incorrect telemetry.
Validation
Closes #2163