Feat 10008 webui performance treeverse#10260
Draft
UdiBen wants to merge 6 commits into
Draft
Conversation
UdiBen
added
exclude-changelog
…itted deletes When displaying objects on a branch, use the committed-only ref (branch@) instead of the full branch ref to list objects. This avoids scanning the staging area twice - once for objects.list and once for refs.changes. For branches with many uncommitted deletes, this significantly improves page load performance. The '@' modifier tells lakeFS to only return committed data, skipping the staging area scan entirely. Fixes #10008
…listing When using committed-only ref (branch@) for objects.list to improve performance, uncommitted added files are not returned by the API. This fix updates mergeResults to also include 'added' type changes in the missingItems filter, ensuring newly uploaded files are shown in the objects list. Fixes the issue reported by @UdiBen: uncommitted additions no longer appear in the objects list when using branch@ for performance.
UdiBen
force-pushed
the
feat-10008-webui-performance-treeverse
branch
from
958171f to
2109d86
Compare
When results from committed-only listing (branch@) are empty, the mergeResults filter `lastResultPath && ...` dropped all changes since lastResultPath was undefined. This prevented uploaded files from appearing in fresh repos with no commits. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> minor
UdiBen
force-pushed
the
feat-10008-webui-performance-treeverse
branch
from
c605109 to
92d1902
Compare
When uploaded files sort lexicographically after all committed objects (e.g. test-upload.txt > lakes.parquet), the lastResultPath filter in mergeResults dropped them. Now the filter is only applied when there are more pages (hasMore), so on the last page all changes are shown. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Removed entries exist in committed data (branch@) and appear on some page of the objects list, so the lastResultPath filter correctly prevents duplicating them. Added entries never appear in committed results, so they need the hasMore bypass to show on the last page. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
📚 Documentation preview at https://pr-10260.docs-lakefs-preview.io/ |
UdiBen
force-pushed
the
feat-10008-webui-performance-treeverse
branch
from
184c82b to
2c11a9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.