Skip tests on changelog#10396
Conversation
|
Do we want this change? Basically it slows down every release in order to run one last integration test before the release. But I want to run that integration test! Integration on a merge to main can fail, and PRs can be force-pushed. Neither of these happens in a "release" context, so I worry that bad things can mistakenly happen if we skip this. |
I understand the concern. But do you there is a real chance of catching a bug at this stage after it already went through all of our CI? In any case, i'm not emotionally invested in this and willing to let go. |
@arielshaqed I don't agree that the changelog is supposed to function as our "gatekeeper" for releases. |
|
Your call; I am intentionally not blocking. Please be sure to communicate any changes to the team. |
idanovo
left a comment
There was a problem hiding this comment.
This change won't work because some of the steps here are required to pass before merging to master, so skipping them will prevent the PR from merging.
Instead, you can try a stub workflow with matching names: keep paths-ignore on the real workflows, add a second workflow triggered on paths: ['CHANGELOG.md'] with no-op jobs whose name: fields exactly match each required check.
| @@ -8,7 +8,7 @@ | |||
| - Normalize file extension case for object previews (#10231) | |||
| - Support StringLike condition operator in policy evaluation (#10249) | |||
| - webui: redesign Data tab with Objects/Tables toggle (#10271) | |||
There was a problem hiding this comment.
Is this part of a demo or a real change?
Closes #10397
Adds
to every workflow that runs on
pull_requestwith no prior filter.