Skip to content

Skip tests on changelog#10396

Draft
ItamarYuran wants to merge 2 commits into
masterfrom
skip-test-on-changelog
Draft

Skip tests on changelog#10396
ItamarYuran wants to merge 2 commits into
masterfrom
skip-test-on-changelog

Conversation

@ItamarYuran
Copy link
Copy Markdown
Contributor

@ItamarYuran ItamarYuran commented May 7, 2026

Closes #10397
Adds

paths-ignore:
      - 'CHANGELOG.md'

to every workflow that runs on pull_request with no prior filter.

@ItamarYuran ItamarYuran requested a review from a team May 7, 2026 09:29
@ItamarYuran ItamarYuran added exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached mostly-human labels May 7, 2026
@arielshaqed
Copy link
Copy Markdown
Contributor

Do we want this change? Basically it slows down every release in order to run one last integration test before the release. But I want to run that integration test! Integration on a merge to main can fail, and PRs can be force-pushed. Neither of these happens in a "release" context, so I worry that bad things can mistakenly happen if we skip this.

@ItamarYuran
Copy link
Copy Markdown
Contributor Author

ItamarYuran commented May 7, 2026

Do we want this change? Basically it slows down every release in order to run one last integration test before the release. But I want to run that integration test! Integration on a merge to main can fail, and PRs can be force-pushed. Neither of these happens in a "release" context, so I worry that bad things can mistakenly happen if we skip this.

I understand the concern. But do you there is a real chance of catching a bug at this stage after it already went through all of our CI? In any case, i'm not emotionally invested in this and willing to let go.

@idanovo
Copy link
Copy Markdown
Contributor

idanovo commented May 7, 2026

Do we want this change? Basically it slows down every release in order to run one last integration test before the release. But I want to run that integration test! Integration on a merge to main can fail, and PRs can be force-pushed. Neither of these happens in a "release" context, so I worry that bad things can mistakenly happen if we skip this.

@arielshaqed I don't agree that the changelog is supposed to function as our "gatekeeper" for releases.
Part of the release proccess os to check that the main CI is green.
We could decide that the changelog PR will be done after the release, and it was a reasonable decision.
We can instead trigger Esti tests to run for a new pre-released version.

@arielshaqed
Copy link
Copy Markdown
Contributor

Your call; I am intentionally not blocking. Please be sure to communicate any changes to the team.

Copy link
Copy Markdown
Contributor

@idanovo idanovo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change won't work because some of the steps here are required to pass before merging to master, so skipping them will prevent the PR from merging.

Instead, you can try a stub workflow with matching names: keep paths-ignore on the real workflows, add a second workflow triggered on paths: ['CHANGELOG.md'] with no-op jobs whose name: fields exactly match each required check.

Comment thread CHANGELOG.md
@@ -8,7 +8,7 @@
- Normalize file extension case for object previews (#10231)
- Support StringLike condition operator in policy evaluation (#10249)
- webui: redesign Data tab with Objects/Tables toggle (#10271)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this part of a demo or a real change?

@ItamarYuran ItamarYuran marked this pull request as draft May 7, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached mostly-human

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skip tests when updating only CHANGELOG.md

3 participants