GC Storage Sharding support#10406
Open
itaigilo wants to merge 1 commit into
Open
Conversation
itaigilo
added
include-changelog
github-actions
Bot
added
area/testing
N-o-Z
approved these changes
May 14, 2026
Comment on lines
+71
to
+75
| // ShardDirPrefix must match shardDirPrefix in pkg/upload/path_provider.go. | ||
| private val ShardDirPrefix = "!" | ||
|
|
||
| // isShardSlice returns true for shard directory names (<ShardDirPrefix><2-hex-chars>). | ||
| // Legacy partition names are 20-char xid strings, so detection is unambiguous. |
Member
There was a problem hiding this comment.
You might want to revise the comments here so they make sense in this context
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10395.
Replicates ent#2445 for OSS.
Change Description
Supporting GC with the sharded namespace storage introduced in Enterprise.
Testing Details
Same as Enterprise,
And Esti tests pass.