fix: restore ready=false for unresolved model in TRITONSERVER_ServerModelIsReady (#508) - #510
Merged
Merged
Conversation
…odelIsReady (#508) #502 refactored ModelIsReady to take an already-resolved Model, moving the GetModel() lookup into TRITONSERVER_ServerModelIsReady with RETURN_IF_STATUS_ERROR. This changed the public contract: a model that was never loaded, was unloaded, or is unregistered now returns a NOT_FOUND error instead of ready=false. Before #502 the lookup failure was swallowed and the call returned ready=false with a success status. The regression surfaced as a failure in test_binding.py::test_server_explicit (and affects every model_is_ready caller, incl. KServe /ready endpoints and the Python in-process API). Treat an unresolvable model as not-ready again while keeping #502's resolved-Model path for the found case.
whoisj
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #508 into
r26.07.Description
#502 refactored
ModelIsReadyto take an already-resolvedModel, moving theGetModel()lookup intoTRITONSERVER_ServerModelIsReadywithRETURN_IF_STATUS_ERROR. This changed the public contract: a model that was never loaded, was unloaded, or is unregistered now returns aNOT_FOUNDerror instead ofready=false. Before #502 the lookup failure was swallowed and the call returnedready=falsewith a success status.The regression surfaced as a failure in
test_binding.py::test_server_explicit(and affects everymodel_is_readycaller, incl. KServe/readyendpoints and the Python in-process API). Treat an unresolvable model as not-ready again while keeping #502's resolved-Modelpath for the found case.Changes
src/tritonserver.cc: whenGetModel()cannot resolve the model, set*ready = falseand return success instead of surfacing the lookup error.Affected Files
src/tritonserver.ccRelated Issues:
Related PRs: