fix: return non-availability errors from TRITONSERVER_ServerModelIsReady - #513
Merged
Conversation
GetModel returns UNAVAILABLE only when the server is not ready; in that case the model is reported not-ready. Any other lookup failure is now surfaced to the caller instead of being masked as ready=false. Signed-off-by: Yingge He <yinggeh@nvidia.com>
whoisj
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Fixes a logic error in
TRITONSERVER_ServerModelIsReady.GetModelreturnsUNAVAILABLE(server not ready) orNOT_FOUND(model not found) only when the server itself is not ready; it may return other error codes in the future for genuine lookup failures. The previous code swallowed everyGetModelfailure and reportedready=false, hiding real errors from the caller. Now only the server-not-ready (UNAVAILABLE) and model-not-found (NOT_FOUND) cases are reported as not-ready; any other error is surfaced.Checklist
<commit_type>: <Title>Commit Type:
Related PRs:
#502
#508
Test plan: