Honor user's CFLAGS - #191
Closed
noloader wants to merge 1 commit into
Closed
Conversation
The project's required CFLAGS are gathered in UTH_CFLAGS and used in the target recipes. It leaves CFLAGS for the user. Also see https://www.gnu.org/prep/standards/html_node/Command-Variables.html
Collaborator
|
This seems reasonable; I like the guidelines in https://www.gnu.org/prep/standards/html_node/Command-Variables.html . However:
|
Quuxplusone
reviewed
Dec 25, 2019
| UTH_CFLAGS += -Wall | ||
| #UTH_CFLAGS += -Wextra | ||
| #UTH_CFLAGS += -std=c89 | ||
| UTH_CFLAGS += ${EXTRA_CFLAGS} |
Collaborator
There was a problem hiding this comment.
Besides my high-level comments in the "Conversation" tab: should this now use ${CFLAGS} instead of ${EXTRA_CFLAGS}? I believe the purpose of EXTRA_CFLAGS was so that the user can pass their own extra stuff, but if we're going to respect their CFLAGS then they don't need this extra mechanism.
Collaborator
|
It's been >4 years; I'm going to close this PR as inactive. However, I've just put up the very similar #271; if its CI is green, I'm inclined to go ahead with it (leaving a few weeks for other folks to weigh in if they care). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project's required
CFLAGSare gathered inUTH_CFLAGSand used in the target recipes. It leavesCFLAGSfor the user. Also see https://www.gnu.org/prep/standards/html_node/Command-Variables.html.