Skip to content

Honor user's CFLAGS - #191

Closed
noloader wants to merge 1 commit into
troydhanson:masterfrom
noloader:master
Closed

Honor user's CFLAGS#191
noloader wants to merge 1 commit into
troydhanson:masterfrom
noloader:master

Conversation

@noloader

Copy link
Copy Markdown

The project's required CFLAGS are gathered in UTH_CFLAGS and used in the target recipes. It leaves CFLAGS for the user. Also see https://www.gnu.org/prep/standards/html_node/Command-Variables.html.

The project's required CFLAGS are gathered in UTH_CFLAGS and used in the target recipes. It leaves CFLAGS for the user. Also see https://www.gnu.org/prep/standards/html_node/Command-Variables.html
@Quuxplusone

Copy link
Copy Markdown
Collaborator

This seems reasonable; I like the guidelines in https://www.gnu.org/prep/standards/html_node/Command-Variables.html . However:

  • this now needs rebasing (thanks for reminding me to merge the no-more-murmurhash patch!)
  • if we're putting the user's CFLAGS at the end of the line, then should we put the user's CPPFLAGS (preprocessor flags) at the end of the line as well?
  • s/UTH_CFLAGS/HASH_CFLAGS/ — let's keep the number of prefixes we use to a minimum

Comment thread tests/Makefile
UTH_CFLAGS += -Wall
#UTH_CFLAGS += -Wextra
#UTH_CFLAGS += -std=c89
UTH_CFLAGS += ${EXTRA_CFLAGS}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides my high-level comments in the "Conversation" tab: should this now use ${CFLAGS} instead of ${EXTRA_CFLAGS}? I believe the purpose of EXTRA_CFLAGS was so that the user can pass their own extra stuff, but if we're going to respect their CFLAGS then they don't need this extra mechanism.

@Quuxplusone

Copy link
Copy Markdown
Collaborator

It's been >4 years; I'm going to close this PR as inactive. However, I've just put up the very similar #271; if its CI is green, I'm inclined to go ahead with it (leaving a few weeks for other folks to weigh in if they care).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants