Add the missing HASH_REPLACE_KEYPTR

[oakaigh]

@troydhanson

HASH_ADD_KEYPTR is used when the structure contains a pointer to the key, rather than the key itself.

Note the inconsistency here. What if we need to replace the structure containing a pointer to the key?

[Quuxplusone]

Seems reasonable to me, but needs new tests for each of the newly added macros.

[oakaigh]

@Quuxplusone

needs new tests for each of the newly added macros.

Writing tests wouldn’t be trivial as long as you understand what this patch is doing. Essentially I’m just bridging &((add)->fieldname) with keyptr to make up the mess created by the original author. So no new test cases should be considered. All you have to do is to change the parameters passed to the function.

TL;DR

Honestly if you don’t want this project to look like a college startup project please merge this pull request as soon as possible. Also if you are the author please consider reorganizing your code base a little bit. Your code is not in standard format (why would you add extraneous braces (e.g. &((add)->fieldname)) around pointers) and this makes it extremely hard to read.