Skip to content

Restrict host key-writes to user ECC slots (block reserved 117-132, keep backup) #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0c-coder wants to merge 1 commit into
base: nemoclaw-openclaw-security-layer
Choose a base branch
from
Open

Restrict host key-writes to user ECC slots (block reserved 117-132, keep backup) #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion onlykey/okcore.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,8 +441,23 @@ void recvmsg(int n)
if (profilemode != NONENCRYPTEDPROFILE)
{
#ifdef STD_VERSION
if (recv_buffer[0] != 0xBA)
if (recv_buffer[0] != 0xBA) {
// A host may only set keys in user slots: RSA 1-4 or ECC
// 101-116. Reserved ECC slots 117-132 are off-limits to host
// key writes, with ONE exception: the designated backup key
// (slot 131 with the backup type flag 0x80), which the app
// legitimately sets via setBackupPassphrase. HMAC (129/130,
// set via the YUBIAUTH/feature-report handler) and derivation
// (128/132, set internally) use other paths that call
// set_private() directly and bypass this dispatch, so they
// are unaffected either way.
if (recv_buffer[5] >= 117 && recv_buffer[5] <= 132 &&
!(recv_buffer[5] == RESERVED_KEY_DEFAULT_BACKUP && (recv_buffer[6] & 0x80))) {
hidprint("Error cannot set key in reserved slot (117-132)");
return;
}
set_private(recv_buffer);
}
#endif
}
}
Expand Down