Repository navigation
ci(deploy): use .nvmrc Node and pin npm 11 - #70
Merged
Merged
Conversation
The deploy job ran on Node 20 and upgraded to npm@latest. npm 12 requires Node ^22.22.2 || ^24.15.0 || >=26, so the Upgrade npm step failed with EBADENGINE and 6.0.5 never published (runs on #67 and #69). Use .nvmrc (v22), matching CI, and pin npm 11 (>= 11.5.1 for trusted publishing; supports Node ^20.17.0 || >=22.9.0). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The deploy workflow's Upgrade npm step has failed on the last two pushes to
main, so 6.0.5 never reached npm (latestis still 6.0.4).npm install -g npm@latestpulled npm 12.2.0, which requires Node^22.22.2 || ^24.15.0 || >=26. The job runs Node 20.20.2, so it fails withEBADENGINE.Changes
setup-nodereadsnode-version-file: .nvmrc(v22), the same as CI's.github/actions/setup, instead of hard-coding20.x.npm@11instead ofnpm@latest. npm 11 supports Node^20.17.0 || >=22.9.0and meets the trusted-publishing (--provenance) floor of 11.5.1. An unpinnedlatestcan break again on the next npm major.Release
Merging this pushes to
main, and 6.0.5 isn't on npm yet, so the deploy runs and publishes 6.0.5 along with its tag and GitHub release. That release includes:CourierClientpassesconnectionIdthrough instead ofclientKeyInboxAction.markAsClicked/trackingIdCourier_iOS5.8.3 → 5.8.6Docs
No customer-facing behavior is restricted. This is CI only, so the docs don't cover it.
🤖 Generated with Claude Code