Skip to content
This repository was archived by the owner on Jul 6, 2026. It is now read-only.

fix: propagate GraphQL errors from updateRecipientPreferences (SUP-561) - #680

Closed
mikemilla wants to merge 1 commit into
mainfrom
fix/sup-561-propagate-preferences-mutation-errors
Closed

mikemilla wants to merge 1 commit into
mainfrom
fix/sup-561-propagate-preferences-mutation-errors

Conversation

@mikemilla

Copy link
Copy Markdown
Contributor

Summary

  • client-graphql: updateRecipientPreferences now checks results.error from the GraphQL mutation and throws instead of silently swallowing errors.
  • react-hooks: Added UPDATE_RECIPIENT_PREFERENCES/ERROR case to the preferences reducer, which clears isUpdating and surfaces the error in state. Added error field to PreferenceState type.
  • Companion to backend fix: https://github.com/trycourier/backend/pull/9319

Test plan

  • Verify existing preference update flows still work (status, routing, digest schedule)
  • Verify that a backend GraphQL error now surfaces in the SDK instead of being silently ignored
  • Verify isUpdating resets to false on error

Made with Cursor

updateRecipientPreferences silently swallowed GraphQL mutation errors.
Now checks results.error and throws, and the preferences reducer handles
the UPDATE_RECIPIENT_PREFERENCES/ERROR action to clear isUpdating and
surface the error in state.

Made-with: Cursor
@linear

linear Bot commented Apr 8, 2026

Copy link
Copy Markdown

@mikemilla mikemilla closed this Apr 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant