Repository navigation
Fix/150 collection permalinks - #170
Conversation
| return addCollectionIRI(filterOutByTerminologies(terminologiesCollection.getTerminologies(), data), terminologiesCollection); | ||
| } | ||
|
|
||
| protected AggregatedApiResponse addCollectionIRI(AggregatedApiResponse response, TerminologyCollection terminologyCollection) { |
There was a problem hiding this comment.
The field should not be http://base4nfdi.de/ts4nfdi/schema/collectionIRI but iri. The iri field should then be mapped to the subject URI in JSON-LD context document:
"@context": {
"iri": "@id"Existing field versionIRI could better be merged into identifier (unless there is a clear definition of its semantic difference, I don't see one).
There was a problem hiding this comment.
Ok, there was a mixup between semantic artefacts and collections. Now this starts making sense to me.
So we want collections to have their permalink as their @id/iri. We do not need collection information in semantic artefacts.
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
{
"@type": "collection:Collection",
"@context": {
"collection": "https://w3id.org/ts4nfdi/collection/",
"terminologies": "collection:terminologies",
"creator": "http://purl.org/dc/terms/creator",
"description": "http://purl.org/dc/terms/description",
"collaborators": "collection:collaborators",
"label": "http://www.w3.org/2000/01/rdf-schema#label"
},
"label": "basics",
"creator": "ralph",
"description": "Just the basics, like rdf, owl, skos, dc, ...",
"collaborators": [],
"terminologies": [
...
],
"@id": "https://w3id.org/ts4nfdi/collection/914d4490-b756-495b-be32-e15d3b3b2f22",
"collection:isPublic": true
} |
|
@nichtich: Do you need the alias |
jusa3
left a comment
jusa3
left a comment
There was a problem hiding this comment.
Works. Can be merged when #170 (comment) is solved.
|
|
||
| @GetMapping("/") | ||
| @GetMapping(value = {"", "/"}, produces = CollectionsJsonLdMessageConverter.MEDIA_TYPE_APPLICATION_LD_JSON_VALUE) |
There was a problem hiding this comment.
This change leads to a duplicate entry in the Swagger docs. Is this intended?
nichtich
left a comment
nichtich
left a comment
There was a problem hiding this comment.
Look like it works as intended.
… trailing slashes for client backward compatibility Resolves #246
This PR resolves #150.
It adds the possibility to use the collection permalink as a query parameter (e.g. https://terminology.services.base4nfdi.de/api-gateway/artefacts?collectionId=https://w3id.org/ts4nfdi/collection/dc45621d-7e40-47ce-9616-4133f0b54edf) and adds the collection permalink to the search result (if the collection uuid or permalink IRI has been used in the query).
The PR introduces the property
http://base4nfdi.de/ts4nfdi/schema/collectionIRIbecause some artefacts have a value forhttp://www.w3.org/2002/07/owl#versionIRIalready set (e.g., OLS uses the versionIRI property), which would then be overwritten.