Repository navigation
Conversation
Update central package versions for SourceLink, logging, xUnit, System.IO.Abstractions, System.CommandLine, Terminal.Gui.Editor, ImageSharp, ReportGenerator, and coverlet. Normalize test project XML formatting and add private runner asset metadata for xunit.runner.visualstudio. Make ConfigPropertyTypeLoad fixture references conditional on restored fixture assets to avoid build failures when unavailable.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Clean restores cannot re-enable the conditioned fixtures, and unrelated dependency upgrades broaden the PR beyond its stated scope.
2 open findings
What changed in this PR
Prevents NETSDK1004 failures by conditionally including optional test fixtures, while also updating unrelated dependencies.
Changes:
- Adds guards around fixture project references.
- Updates test-runner package metadata.
- Upgrades multiple centrally managed dependencies.
| File | Description |
|---|---|
Directory.Packages.props |
Upgrades package versions. |
Tests/IntegrationTests/IntegrationTests.csproj |
Updates runner metadata and formatting. |
Tests/PerformanceTests/PerformanceTests.csproj |
Updates runner metadata. |
Tests/StressTests/StressTests.csproj |
Updates runner metadata and formatting. |
Tests/UnitTests.Legacy/UnitTests.Legacy.csproj |
Updates runner metadata and formatting. |
Tests/UnitTests.NonParallelizable/UnitTests.NonParallelizable.csproj |
Conditionally includes fixtures and updates runner metadata. |
Tests/UnitTestsParallelizable/UnitTests.Parallelizable.csproj |
Updates runner metadata and formatting. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Downgrade SixLabors.ImageSharp from 4.1.3 to 3.1.12 in Directory.Packages.props to restore compatibility.
Update UnitTests.NonParallelizable to reference the two ConfigPropertyTypeLoad fixture projects whenever their project files exist and IncludeTestFixtures is not false, so restore works from a clean checkout; add a note on opting out with IncludeTestFixtures=false.
Collaborator
Author
|
It was a problem with Visual Studio. After restarting the machine, this problem no longer occurs. That's why I'm closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Summary
This PR prevents local/CI builds from failing with NETSDK1004 when optional test fixture projects under Tests/TestAssets are not present or restored. It makes the ProjectReference entries for those TestAssets conditional on the presence of both the referenced .csproj and its obj/project.assets.json.
Changes
Rationale
Some test fixture projects are optional and not always checked out or restored in developer machines or CI. Without project.assets.json present, the SDK raises NETSDK1004 during package resolution. The change avoids forcing package resolution for absent test assets while preserving behavior when they are available.
Testing
Pull Request checklist:
CTRL-K-Dto automatically reformat your files before committing.dotnet testbefore commit///style comments)