Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,10 @@ PublishScripts/
*.nupkg
# NuGet Symbol Packages
*.snupkg
# TEMP: vendored Terminal.Gui 2.5.0 preview built from tui-cs/Terminal.Gui#5416.
# Remove once 2.5.x is published to nuget.org.
!local_packages/*.nupkg
!local_packages/*.snupkg
# The packages folder can be ignored because of Package Restore
**/[Pp]ackages/*
# except build/, which is used as an MSBuild target.
Expand Down
4 changes: 3 additions & 1 deletion Showcase/Showcase.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Terminal.Gui" Version="2.4.5" />
<!-- TEMP: vendored 2.5.0 preview from tui-cs/Terminal.Gui#5416 (see ../local_packages
and nuget.config). Swap to the public 2.5.x package once it ships on nuget.org. -->
<PackageReference Include="Terminal.Gui" Version="2.5.0-tig-remove-cm-followup.1" />
</ItemGroup>

</Project>
Binary file not shown.
Binary file not shown.
10 changes: 10 additions & 0 deletions nuget.config
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?xml version="1.0" encoding="utf-8"?>
<configuration>
<packageSources>
<!-- TEMP: local source for the Terminal.Gui 2.5.0 preview package built from
tui-cs/Terminal.Gui#5416 (ConfigurationManager removal). Remove this source
and ./local_packages/ once Terminal.Gui 2.5.x is published to nuget.org. -->
<add key="tgui-pr-5416" value="./local_packages" />
<add key="nuget.org" value="https://api.nuget.org/v3/index.json" />
</packageSources>
</configuration>
13 changes: 8 additions & 5 deletions src/TerminalGuiDesigner.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -161,15 +161,18 @@
<PackageReference Include="Basic.Reference.Assemblies.Net80" Version="1.7.7" />
<PackageReference Include="CommandLineParser" Version="2.9.1" />
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.11.0" />
<PackageReference Include="Microsoft.Extensions.Configuration" Version="10.0.0" />
<PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="10.0.0" />
<PackageReference Include="Microsoft.Extensions.Configuration.FileExtensions" Version="10.0.0" />
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="10.0.0" />
<!-- TEMP: bumped 10.0.0 -> 10.0.11 to satisfy Terminal.Gui 2.5.0 preview dependencies (NU1605). -->
<PackageReference Include="Microsoft.Extensions.Configuration" Version="10.0.11" />
<PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="10.0.11" />
<PackageReference Include="Microsoft.Extensions.Configuration.FileExtensions" Version="10.0.11" />
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="10.0.11" />
<PackageReference Include="NetEscapades.Configuration.Yaml" Version="3.1.0" />
<PackageReference Include="Serilog" Version="4.2.0" />
<PackageReference Include="Serilog.Extensions.Logging" Version="9.0.0" />
<PackageReference Include="Serilog.Sinks.File" Version="6.0.0" />
<PackageReference Include="Terminal.Gui" Version="2.4.5" />
<!-- TEMP: vendored 2.5.0 preview from tui-cs/Terminal.Gui#5416 (see ./local_packages
and nuget.config). Swap to the public 2.5.x package once it ships on nuget.org. -->
<PackageReference Include="Terminal.Gui" Version="2.5.0-tig-remove-cm-followup.1" />

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep the unpublished dependency out of releases

When a version tag triggers the publish step in .github/workflows/build.yml, the packed global tool will declare this preview as a dependency, but nuget.config and local_packages/ are repository-only and the workflow pushes only TerminalGuiDesigner*.nupkg to nuget.org. Because the comment establishes that this Terminal.Gui version is not available there, installing the published tool from the normal source will fail dependency resolution; either prevent preview builds from being published or make the vendored dependency available to package consumers.

Useful? React with 👍 / 👎.

<PackageReference Include="nlog" Version="5.3.3" />
<PackageReference Include="Basic.Reference.Assemblies.Net100" Version="1.7.7" />
<PackageReference Include="System.CodeDom" Version="10.0.0" />
Expand Down
Loading