GSE Compatibility - #1000
Open
Thrumbar wants to merge 2 commits into
Open
Conversation
Update for button override from GSE so it would work with Dominoes. Sorta unasked but neverless here it is...
Author
|
This may become moot with secret table changes for actionbars in 12.0.7... Hope they don't further expand the secret tables.. |
Author
|
Workin fine so far |
Patch to fix so that GSE override does not mess with vehicle swap bar causing buttons to not function as intended
Member
|
Sorry, I thought I had responded earlier to this. I hadn't yet really had time to sit through and review the PR. Are you able to remove the Ace Libraries from your commit? It looks like you based this on a "built" version of the addon instead of the repo itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update for button override from GSE so it would work with Dominoes. Sorta unasked but neverless here it is... This is my attempt to get Dominoes to mirror Blizzards actionbars while retaining it's unique style and allow addon that work with blizzard actionbars to work here... Just to show do not expect it to be adopted...