v6: Albums Example layout fixes #42357
+13
−13
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,7 +30,7 @@ import Placeholder from "@shortcodes/Placeholder.astro" | |
| <svg xmlns="http://www.w3.org/2000/svg" width="20" height="20" fill="none" stroke="currentColor" stroke-linecap="round" stroke-linejoin="round" stroke-width="2" aria-hidden="true" class="me-2" viewBox="0 0 24 24"><path d="M23 19a2 2 0 0 1-2 2H3a2 2 0 0 1-2-2V8a2 2 0 0 1 2-2h4l2-3h6l2 3h4a2 2 0 0 1 2 2z"/><circle cx="12" cy="13" r="4"/></svg> | ||
| <strong>Album</strong> | ||
| </a> | ||
| <button class="btn-icon navbar-toggler" type="button" data-bs-toggle="collapse" data-bs-target="#navbarHeader" aria-controls="navbarHeader" aria-expanded="false" aria-label="Toggle navigation"> | ||
| <svg class="navbar-toggler-icon" xmlns="http://www.w3.org/2000/svg" width="20" height="20" viewBox="0 0 16 16" fill="none" stroke="currentColor" stroke-width="1" stroke-linecap="round"><path d="M1 3.5h14M1 8h14M1 12.5h14"/></svg> | ||
| </button> | ||
| </div> | ||
|
|
@@ -45,14 +45,14 @@ import Placeholder from "@shortcodes/Placeholder.astro" | |
| <h1 class="fw-light">Album example</h1> | ||
| <p class="lead fg-2">Something short and leading about the collection below—its contents, the creator, etc. Make it short and sweet, but not too short so folks don’t simply skip over it entirely.</p> | ||
| <p> | ||
| <a href="#" class="btn-solid theme-primary m-2">Main call to action</a> | ||
| <a href="#" class="btn-solid theme-secondary m-2">Secondary action</a> | ||
| </p> | ||
| </div> | ||
| </div> | ||
| </section> | ||
|
|
||
| <div class="album py-5 bg-1"> | ||
| <div class="container"> | ||
|
|
||
| <div class="row row-cols-1 sm:row-cols-2 md:row-cols-3 g-3"> | ||
|
|
@@ -61,7 +61,7 @@ import Placeholder from "@shortcodes/Placeholder.astro" | |
| <Placeholder width="100%" height="225" background="#55595c" color="#eceeef" class="card-img-top" text="Thumbnail" /> | ||
| <div class="card-body"> | ||
| <p class="card-text">This is a wider card with supporting text below as a natural lead-in to additional content. This content is a little bit longer.</p> | ||
| <div class="d-flex justify-content-between align-items-center w-100"> | ||
|
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment. this change was intentional, the div was not full-width of the containing card before.... see |
||
| <div class="btn-group"> | ||
| <button type="button" class="btn-outline theme-secondary btn-sm">View</button> | ||
| <button type="button" class="btn-outline theme-secondary btn-sm">Edit</button> | ||
|
|
@@ -76,7 +76,7 @@ import Placeholder from "@shortcodes/Placeholder.astro" | |
| <Placeholder width="100%" height="225" background="#55595c" color="#eceeef" class="card-img-top" text="Thumbnail" /> | ||
| <div class="card-body"> | ||
| <p class="card-text">This is a wider card with supporting text below as a natural lead-in to additional content. This content is a little bit longer.</p> | ||
| <div class="d-flex justify-content-between align-items-center w-100"> | ||
| <div class="btn-group"> | ||
| <button type="button" class="btn-outline theme-secondary btn-sm">View</button> | ||
| <button type="button" class="btn-outline theme-secondary btn-sm">Edit</button> | ||
|
|
@@ -91,7 +91,7 @@ import Placeholder from "@shortcodes/Placeholder.astro" | |
| <Placeholder width="100%" height="225" background="#55595c" color="#eceeef" class="card-img-top" text="Thumbnail" /> | ||
| <div class="card-body"> | ||
| <p class="card-text">This is a wider card with supporting text below as a natural lead-in to additional content. This content is a little bit longer.</p> | ||
| <div class="d-flex justify-content-between align-items-center w-100"> | ||
| <div class="btn-group"> | ||
| <button type="button" class="btn-outline theme-secondary btn-sm">View</button> | ||
| <button type="button" class="btn-outline theme-secondary btn-sm">Edit</button> | ||
|
|
@@ -107,7 +107,7 @@ import Placeholder from "@shortcodes/Placeholder.astro" | |
| <Placeholder width="100%" height="225" background="#55595c" color="#eceeef" class="card-img-top" text="Thumbnail" /> | ||
| <div class="card-body"> | ||
| <p class="card-text">This is a wider card with supporting text below as a natural lead-in to additional content. This content is a little bit longer.</p> | ||
| <div class="d-flex justify-content-between align-items-center w-100"> | ||
| <div class="btn-group"> | ||
| <button type="button" class="btn-outline theme-secondary btn-sm">View</button> | ||
| <button type="button" class="btn-outline theme-secondary btn-sm">Edit</button> | ||
|
|
@@ -122,7 +122,7 @@ import Placeholder from "@shortcodes/Placeholder.astro" | |
| <Placeholder width="100%" height="225" background="#55595c" color="#eceeef" class="card-img-top" text="Thumbnail" /> | ||
| <div class="card-body"> | ||
| <p class="card-text">This is a wider card with supporting text below as a natural lead-in to additional content. This content is a little bit longer.</p> | ||
| <div class="d-flex justify-content-between align-items-center w-100"> | ||
| <div class="btn-group"> | ||
| <button type="button" class="btn-outline theme-secondary btn-sm">View</button> | ||
| <button type="button" class="btn-outline theme-secondary btn-sm">Edit</button> | ||
|
|
@@ -137,7 +137,7 @@ import Placeholder from "@shortcodes/Placeholder.astro" | |
| <Placeholder width="100%" height="225" background="#55595c" color="#eceeef" class="card-img-top" text="Thumbnail" /> | ||
| <div class="card-body"> | ||
| <p class="card-text">This is a wider card with supporting text below as a natural lead-in to additional content. This content is a little bit longer.</p> | ||
| <div class="d-flex justify-content-between align-items-center w-100"> | ||
| <div class="btn-group"> | ||
| <button type="button" class="btn-outline theme-secondary btn-sm">View</button> | ||
| <button type="button" class="btn-outline theme-secondary btn-sm">Edit</button> | ||
|
|
@@ -153,7 +153,7 @@ import Placeholder from "@shortcodes/Placeholder.astro" | |
| <Placeholder width="100%" height="225" background="#55595c" color="#eceeef" class="card-img-top" text="Thumbnail" /> | ||
| <div class="card-body"> | ||
| <p class="card-text">This is a wider card with supporting text below as a natural lead-in to additional content. This content is a little bit longer.</p> | ||
| <div class="d-flex justify-content-between align-items-center w-100"> | ||
| <div class="btn-group"> | ||
| <button type="button" class="btn-outline theme-secondary btn-sm">View</button> | ||
| <button type="button" class="btn-outline theme-secondary btn-sm">Edit</button> | ||
|
|
@@ -168,7 +168,7 @@ import Placeholder from "@shortcodes/Placeholder.astro" | |
| <Placeholder width="100%" height="225" background="#55595c" color="#eceeef" class="card-img-top" text="Thumbnail" /> | ||
| <div class="card-body"> | ||
| <p class="card-text">This is a wider card with supporting text below as a natural lead-in to additional content. This content is a little bit longer.</p> | ||
| <div class="d-flex justify-content-between align-items-center w-100"> | ||
| <div class="btn-group"> | ||
| <button type="button" class="btn-outline theme-secondary btn-sm">View</button> | ||
| <button type="button" class="btn-outline theme-secondary btn-sm">Edit</button> | ||
|
|
@@ -183,7 +183,7 @@ import Placeholder from "@shortcodes/Placeholder.astro" | |
| <Placeholder width="100%" height="225" background="#55595c" color="#eceeef" class="card-img-top" text="Thumbnail" /> | ||
| <div class="card-body"> | ||
| <p class="card-text">This is a wider card with supporting text below as a natural lead-in to additional content. This content is a little bit longer.</p> | ||
| <div class="d-flex justify-content-between align-items-center w-100"> | ||
| <div class="btn-group"> | ||
| <button type="button" class="btn-outline theme-secondary btn-sm">View</button> | ||
| <button type="button" class="btn-outline theme-secondary btn-sm">Edit</button> | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
m-2adds horizontal margin on both sides of each button, which can create unintended outer spacing (e.g., extra left margin before the first button and extra right margin after the last). If the goal is just spacing between the buttons, prefer using directional spacing (e.g.,me-2on the first button while keepingmy-2for vertical rhythm) or apply a parentgap-*with a flex wrapper so only inter-button spacing is affected.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was an intentional change on my part. I thought the buttons were too close before... I can revert it though if requested.