v6: accordions - hide default WebKit details marker (old Safari)#42401
Open
coliff wants to merge 1 commit intotwbs:v6-devfrom
Open
v6: accordions - hide default WebKit details marker (old Safari)#42401coliff wants to merge 1 commit intotwbs:v6-devfrom
coliff wants to merge 1 commit intotwbs:v6-devfrom
Conversation
Suppress the native disclosure marker in WebKit by adding &::-webkit-details-marker { display: none; } to the accordion button styles. This prevents the browser's default triangle from overlapping the custom .accordion-icon and ensures consistent appearance across browsers
Issue discovered using Browserstack.
See comment: https://github.com/orgs/twbs/discussions/42398#discussion-10018925
coliff
changed the title
There was a problem hiding this comment.
Pull request overview
This PR fixes a Safari/WebKit rendering issue in the v6 accordion by suppressing the native <summary> disclosure marker so it doesn’t overlap Bootstrap’s custom .accordion-icon, improving cross-browser visual consistency (notably on older Safari versions).
Changes:
- Add a WebKit-specific rule to hide the default
details/summarymarker in.accordion-header.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Curious what version of Safari you're looking at? |
Contributor
Author
I posted in the linked discussion. It’s safari 17.3 and older it’s broken in. Screenshot above is 16.5 with the fix. I updated the pr title to say (old safari) :-) |
coliff
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description / Motivation & Context
Suppress the native disclosure marker in WebKit by adding &::-webkit-details-marker { display: none; } to the accordion button styles. This prevents the browser's default triangle from overlapping the custom .accordion-icon and ensures consistent appearance across browsers
Issue discovered using Browserstack.
See comment: https://github.com/orgs/twbs/discussions/42398#discussion-10018925
Improves design on older Safari versions.
Type of changes
Checklist
npm run lint)Live previews
Screenshot of deploy preview (Safari 16.5):