Skip to content

fix: Add block passing in serialize-list method implementations - #516

Merged
AsabuHere merged 4 commits into
mainfrom
block_parsing_ruby
Jul 17, 2023
Merged

fix: Add block passing in serialize-list method implementations#516
AsabuHere merged 4 commits into
mainfrom
block_parsing_ruby

Conversation

@AsabuHere

@AsabuHere AsabuHere commented Jul 5, 2023

Copy link
Copy Markdown
Contributor

Fixes

A short description of what this PR does.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • Run make test-docker
  • Verify affected language:
    • Generate twilio-go from our OpenAPI specification using the build_twilio_go.py using python examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-go and inspect the diff
    • Run make test in twilio-go
    • Create a pull request in twilio-go
    • Provide a link below to the pull request
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please create a GitHub Issue in this repository.

@AsabuHere
AsabuHere requested review from kridai and shrutiburman July 5, 2023 18:23
kridai
kridai approved these changes Jul 6, 2023
View reviewed changes

@kridai kridai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shrutiburman

shrutiburman commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

Reference PR: twilio/twilio-ruby#667
Better to add example cases in examples folder to validate the changes.

@sonarqubecloud

sonarqubecloud Bot commented Jul 13, 2023

Copy link
Copy Markdown

[twilio-oai-generator-php] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud

sonarqubecloud Bot commented Jul 13, 2023

Copy link
Copy Markdown

[twilio-oai-generator-java] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud

sonarqubecloud Bot commented Jul 13, 2023

Copy link
Copy Markdown

[twilio-oai-generator-go] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud

sonarqubecloud Bot commented Jul 13, 2023

Copy link
Copy Markdown

[twilio-oai-generator-ruby] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud

sonarqubecloud Bot commented Jul 13, 2023

Copy link
Copy Markdown

[twilio-oai-generator-node] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

@sonarqubecloud

sonarqubecloud Bot commented Jul 13, 2023

Copy link
Copy Markdown

[twilio-oai-generator-python] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AsabuHere
AsabuHere merged commit 861ce5e into main Jul 17, 2023
@AsabuHere
AsabuHere deleted the block_parsing_ruby branch July 17, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kridai kridai kridai approved these changes
@shrutiburman shrutiburman shrutiburman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AsabuHere @shrutiburman @kridai