Skip to content

chore: update cargo-dist, drop self-updater and PR release dry-run#946

Merged
scarmuega merged 1 commit into
mainfrom
chore/cargo-dist-no-updater-no-pr-check
Jun 15, 2026
Merged

chore: update cargo-dist, drop self-updater and PR release dry-run#946
scarmuega merged 1 commit into
mainfrom
chore/cargo-dist-no-updater-no-pr-check

Conversation

@scarmuega

@scarmuega scarmuega commented Jun 15, 2026

Copy link
Copy Markdown
Member

What

Bump cargo-dist to 0.30.3 and adjust its config in dist-workspace.toml:

  • install-updater = false — stop bundling the axoupdate self-updater in the generated installers.
  • pr-run-mode = "skip" — don't run the release dry-run on pull requests. The release workflow (release.yml) now fires only on version tags; PR validation already lives in ci.yml.

.github/workflows/release.yml is regenerated from dist-workspace.toml to match.

Why

  • The self-updater isn't wanted for this distribution.
  • The dist plan dry-run ran on every PR for no benefit — ci.yml (fmt/clippy/test/check) is the real PR gate.

Verification

  • dist generate --check is clean (TOML ↔ YAML in sync).
  • dist plan succeeds: all four targets and all installers (shell, powershell, npm, homebrew) present, no updater artifact.
  • release.yml on: block now contains only push: tags:.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated release automation configuration and build tooling version
    • Modified release workflow to trigger only on tagged push events
    • Disabled automatic updater installer generation in releases

Bump cargo-dist to 0.30.3 and adjust its config:

- install-updater = false: stop bundling the axoupdate self-updater in
  the generated installers.
- pr-run-mode = "skip": don't run the release dry-run on pull requests
  (PR validation already lives in ci.yml); the release workflow now fires
  only on version tags.

release.yml is regenerated from dist-workspace.toml accordingly.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@scarmuega
scarmuega requested a review from paulobressan as a code owner June 15, 2026 00:37
@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 795c2d32-a165-498c-b16a-484490bf0dbf

📥 Commits

Reviewing files that changed from the base of the PR and between 439c4db and f9e4e2b.

📒 Files selected for processing (2)
  • .github/workflows/release.yml
  • dist-workspace.toml

📝 Walkthrough

Walkthrough

Upgrades cargo-dist from 0.29.0 to 0.30.3 in both dist-workspace.toml and the release workflow installer URL. Removes the pull_request trigger from the release workflow, disables the updater installer, sets pr-run-mode = "skip", and adds a needs.plan.result == 'success' guard on the host job.

Changes

Release pipeline upgrade and hardening

Layer / File(s) Summary
cargo-dist version bump and PR/updater behavior
dist-workspace.toml
cargo-dist-version updated to 0.30.3; install-updater = false added to disable updater installer generation; pr-run-mode = "skip" added to suppress PR dry-run behavior.
Release workflow trigger, installer, and host gate
.github/workflows/release.yml
pull_request: trigger removed so the workflow fires only on tag pushes; installer download URL updated to v0.30.3; host job if: condition extended with needs.plan.result == 'success'.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Possibly related PRs

  • txpipe/oura#932: Modifies the same release.yml gating/publishing behavior and dist-workspace.toml cargo-dist configuration.

Suggested reviewers

  • paulobressan

Poem

🐇 Hop, hop, the tags now reign,
No pull requests shall trigger pain.
Version bumped to thirty-three,
The updater's gone — we run free!
Release the carrot, ship the crate! 🥕

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/cargo-dist-no-updater-no-pr-check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@scarmuega
scarmuega merged commit fcb60cc into main Jun 15, 2026
4 of 5 checks passed
@scarmuega
scarmuega deleted the chore/cargo-dist-no-updater-no-pr-check branch June 15, 2026 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant