ci: fix silent no-op crates.io publish#782
Conversation
|
Warning Review limit reached
More reviews will be available in 23 minutes and 54 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe release workflow now isolates the cargo publish step from workspace metadata configuration and adds a post-publish verification loop. The new verification polls the crates.io index for the released ChangesRelease workflow publish improvements
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
fb61b57 to
b1f1f0c
Compare
b1f1f0c to
3c1bbb9
Compare
Problem
The
v1.1.0release CI job ran green but published nothing to crates.io. The publish step (cargo release publish --workspace --execute ...) printed only its plan line (Publishing pallas-codec, …) and exited0without uploading a single crate.Root cause: the workspace
Cargo.tomlcarriespublish = falseis intentional — it lets a localcargo release <version>do bump + commit + tag only. But cargo-release reads that same config in CI, socargo release publishtreated every crate as do-not-publish and no-op'd while still exiting0. The green check hid it.Fix
--isolatedto the CI publish command so cargo-release ignores[workspace.metadata.release]andpublishdefaults back totrue— CI only, the local tag-only flow is unchanged. Verified against thev1.1.0tree: without it → silent no-op; with it →Uploading pallas-codec v1.1.0 ….pallascrate at the tag's version and fails the job if it never appears, so a no-op publish can never report success again. Since all crates publish together pinned to=version,pallasbeing live implies the rest are.Note
v1.1.0has already been published manually to crates.io to unblock consumers; this PR prevents a recurrence on the next release.Summary by CodeRabbit